Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: testing snapshot container #691

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

joshLong145
Copy link

@joshLong145 joshLong145 commented Oct 15, 2024

testing new container with snapshot in ci

Snap shots now load and work, speeding up ci. but volume is still needed for an unknown reason see pr: https://github.com/LIT-Protocol/lit-assets/pull/1518

This pr removes the need to run npm install within iit-assets/blockchain/contracts and removes the deployment step replaced with loading state from snapshot.

Ansonhkg

This comment was marked as resolved.

@Ansonhkg Ansonhkg self-requested a review October 17, 2024 13:39
Copy link
Collaborator

@Ansonhkg Ansonhkg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the volume a blocker to getting this PR merged?

@joshLong145
Copy link
Author

Is the volume a blocker to getting this PR merged?

The container used in this PR was published as a test. But does provide some improvements to CI times as you no longer need to install modules for lit assets. The test container was published to a tag so it should persist if you want to merge this pr as is, if not can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants