-
-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): add cycle-layout command #556
Conversation
toggle_layout
@LGUG2Z - Thanks for the initial review, please feel free to take a look again, I haven't tested this on my Windows machine but will try doing it in a few hours from now. Also marked it as ready for review, wanted to wait until we agree that this is something that could be useful. I also think we should implement a reverse toggle as a next step, to ensure users can switch back to the last used layout, should be fairly straight forward after this lands in. Thank you for reviewing the PR, appreciate it. |
I'm also currently reviewing this from my Macbook 😅 I'll try this out when I'm back at my desktop later today. For the reverse toggle, I think we can have the We might as well add the reversing in the same PR since the rest of the |
43ac1fc
to
bbdcd35
Compare
No problem! I thought it might be a bit late for you with the time difference between Seattle and India. 😅 Thanks for all the work on this; I'll wait for the build and run it for a few days before merging it in- it should be part of the next versioned release 🎉 |
Appreciate it! 🚀 I can't wait to add a keybinding in my config for this. Thanks for being considerate about the timings. 💯 |
Co-authored-by: Kushashwa Ravi Shrimali <kushashwaravishrimali@gmail.com>
* Command to ToggleLayout * Just improve logic of figuring out next layout * Addr review: rename to "Cycle" instead of toggle, and add a small comment * As per review comments, implement cycle method on DefaultLayout * I forgot to remove this, my bad * feat(cli): fixups for cycle-layout cmd * Update komorebic/src/main.rs Co-authored-by: Kushashwa Ravi Shrimali <kushashwaravishrimali@gmail.com> --------- Co-authored-by: LGUG2Z <jadeiqbal@fastmail.com> Co-authored-by: جاد <LGUG2Z@users.noreply.github.com>
Resolves issue: #555 (comment).
This PR:
Cycle(CycleDirection)
usingcycle_next
andcycle_previous
on DefaultLayout