Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor GroupMetadata{V3,V2} constructors #96

Merged
merged 1 commit into from
Nov 10, 2024

Conversation

LDeakin
Copy link
Owner

@LDeakin LDeakin commented Nov 10, 2024

No description provided.

@LDeakin LDeakin force-pushed the refactor_group_metadata_constructors branch from 5020dfc to b204ef3 Compare November 10, 2024 04:52
Copy link

codecov bot commented Nov 10, 2024

Codecov Report

Attention: Patch coverage is 10.25641% with 35 lines in your changes missing coverage. Please review.

Project coverage is 81.95%. Comparing base (be1727e) to head (b204ef3).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
zarrs_metadata/src/v2/group.rs 0.00% 21 Missing ⚠️
zarrs_metadata/src/v3/group.rs 26.66% 11 Missing ⚠️
zarrs_metadata/src/v2_to_v3.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #96      +/-   ##
==========================================
- Coverage   82.06%   81.95%   -0.12%     
==========================================
  Files         166      166              
  Lines       23387    23415      +28     
==========================================
- Hits        19193    19190       -3     
- Misses       4194     4225      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LDeakin LDeakin merged commit a81bc89 into main Nov 10, 2024
22 checks passed
@LDeakin LDeakin deleted the refactor_group_metadata_constructors branch November 10, 2024 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant