Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ArraySubset iterators #7

Merged
merged 2 commits into from
Feb 12, 2024
Merged

Refactor ArraySubset iterators #7

merged 2 commits into from
Feb 12, 2024

Conversation

LDeakin
Copy link
Owner

@LDeakin LDeakin commented Feb 12, 2024

This ArraySubset iterator refactor uncouples iterator lifetimes from the array subset and adds parallel iterator support (into_par_iter()) for some iterators. Downstream users doing array subset iteration will need to adjust calls from

array_subset.iter_<variant>(...)

to

array_subset.<variant>(...).into_iter()

Copy link

codecov bot commented Feb 12, 2024

Codecov Report

Attention: 121 lines in your changes are missing coverage. Please review.

Comparison is base (8d5a27c) 75.70% compared to head (b1be44a) 75.76%.

Files Patch % Lines
src/array/array_async_readable.rs 0.00% 30 Missing ⚠️
src/array/array_async_writable.rs 0.00% 20 Missing ⚠️
src/array_subset/iterators/indices_iterator.rs 88.72% 15 Missing ⚠️
src/array_subset/iterators/chunks_iterator.rs 90.17% 11 Missing ⚠️
src/array/array_async_readable_writable.rs 0.00% 8 Missing ⚠️
...ay_subset/iterators/contiguous_indices_iterator.rs 50.00% 8 Missing ⚠️
...terators/contiguous_linearised_indices_iterator.rs 77.77% 8 Missing ⚠️
...ay_subset/iterators/linearised_indices_iterator.rs 81.39% 8 Missing ⚠️
src/array/array_sync_writable.rs 0.00% 5 Missing ⚠️
src/array/array_sync_readable.rs 66.66% 4 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #7      +/-   ##
==========================================
+ Coverage   75.70%   75.76%   +0.06%     
==========================================
  Files         124      124              
  Lines       17878    18084     +206     
==========================================
+ Hits        13535    13702     +167     
- Misses       4343     4382      +39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…tation

Iterators are no longer in the `array_subset` namespace.
@LDeakin LDeakin merged commit ca01e66 into main Feb 12, 2024
18 checks passed
@LDeakin LDeakin deleted the array_subset_iterators branch February 12, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant