Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a major refactor of codec traits and the array structure.
Previously, various codec and array methods had three variants:
<method>_opt(..., parallel: bool)
supporting optional parallelism<method>(...)
, serialpar_<method>(...)
, parallelNow, there are just two variants:
<method>_opt(..., options: &SomeOptionsStruct)
<method>(...)
, default options (maximum concurrency)This new API provides finer-grained control of the number of concurrent operations executed within an encode/decode method.
Most internal operations use the
_opt
API. The efficient/maximum concurrency of codecs can be queried (presently, this may not be accurate for many codecs).This has the potential to improve performance and reduce memory usage. For example, a call of
Array::retrieve_chunks
which decodes multiple shards could recognise that the inner chunks can be decoded with massive parallelisation, and thus only decode one shard at a time. This behaviour is not yet implemented, but will follow shortly.