Tutorial: Fix broken check for format in match statement #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want the check to succeed if "format" is D32_SFLOAT_S8_UINT or D24_UNORM_S8_UINT, so the operator should be logical OR, not bitwise OR.
|
The use of |
|
I didn't appreciate that Rust match arms work like this and the text you've added is super helpful. Hopefully most other people using your tutorial will have more Rust knowledge than I obviously do! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want the check to succeed if
formatisD32_SFLOAT_S8_UINTorD24_UNORM_S8_UINT, so the operator should be logical OR, not bitwise OR.