Fixed typo and updated tests

KulikDM · Jan 25, 2024 · 27352ac · 27352ac
1 parent 95657cb
commit 27352ac
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 2 deletions.
diff --git a/pythresh/test/test_chau.py b/pythresh/test/test_chau.py
@@ -53,6 +53,10 @@ def test_prediction_labels(self):
             self.thres = CHAU(method=method)
             pred_labels = self.thres.eval(scores)
             assert (self.thres.thresh_ is not None)
+            assert (self.thres.dscores_ is not None)
+
+            assert (self.thres.dscores_.min() == 0)
+            assert (self.thres.dscores_.max() == 1)
 
             assert_equal(pred_labels.shape, self.y_train.shape)
 

diff --git a/pythresh/test/test_decomp.py b/pythresh/test/test_decomp.py
@@ -52,7 +52,10 @@ def test_prediction_labels(self):
 
             self.thres = DECOMP(method=method)
             pred_labels = self.thres.eval(scores)
-            assert (self.thres.thresh_ is not None)
+            assert (self.thres.dscores_ is not None)
+
+            assert (self.thres.dscores_.min() == 0)
+            assert (self.thres.dscores_.max() == 1)
 
             assert_equal(pred_labels.shape, self.y_train.shape)
 

diff --git a/pythresh/test/test_dsn.py b/pythresh/test/test_dsn.py
@@ -54,6 +54,10 @@ def test_prediction_labels(self):
             self.thres = DSN(metric=metric)
             pred_labels = self.thres.eval(scores)
             assert (self.thres.thresh_ is not None)
+            assert (self.thres.dscores_ is not None)
+
+            assert (self.thres.dscores_.min() == 0)
+            assert (self.thres.dscores_.max() == 1)
 
             assert_equal(pred_labels.shape, self.y_train.shape)
 

diff --git a/pythresh/test/test_filter.py b/pythresh/test/test_filter.py
@@ -58,6 +58,10 @@ def test_prediction_labels(self):
             self.thres = FILTER(method=method, sigma=sigma)
             pred_labels = self.thres.eval(scores)
             assert (self.thres.thresh_ is not None)
+            assert (self.thres.dscores_ is not None)
+
+            assert (self.thres.dscores_.min() == 0)
+            assert (self.thres.dscores_.max() == 1)
 
             assert_equal(pred_labels.shape, self.y_train.shape)
 

diff --git a/pythresh/thresholds/cpd.py b/pythresh/thresholds/cpd.py
@@ -36,7 +36,7 @@ class CPD(BaseThresholder):
        Attributes
        ----------
 
-       thres_ : threshold value that separates inliers from outliers
+       thresh_ : threshold value that separates inliers from outliers
 
        dscores_ : 1D array of decomposed decision scores