Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building with
-DKOMPUTE_OPT_USE_BUILT_IN_FMT=OFF
usingfmt
from vcpkg, I was getting build errors inManager.cpp
sayingerror: no member named 'join' in namespace 'fmt'
.join
is defined in<fmt/ranges.h>
which wasn't included. I'm not sure how kompute can build with the built in fmt.Another trivial thing was that the
<set>
and<unordered_map>
headers were not used inManager.hpp
so I moved them toManager.cpp
.