expose vulkan_compile_shader with CMake install
#382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested this manually with a local install of this branch and a simple standalone CMake project (basically example/array_multiplication with the |
|
Thank you - DCO check requires signed commit, see: https://github.com/KomputeProject/kompute/pull/382/checks?check_run_id=28023370279 |
kwsp
force-pushed
the
cmake-vulkan-compiler
branch
from
0034ccf
to
c88d3f7
Compare
|
done |
|
Unfortunately still DCO not passing |
Signed-off-by: tnie <tnie@tuta.io>
kwsp
force-pushed
the
cmake-vulkan-compiler
branch
from
c88d3f7
to
48a954e
Compare
|
done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#381
This would enable CMake users to use
vulkan_compile_shaderthrough the CMake install route. Important step for packaging Kompute for VCPKG, which I'm working on.