Python build fixes #372
Merged
Python build fixes #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The macros were all named wrong, but also they use fmt::format without including the fmt header. Signed-off-by: Dave Airlie <airlied@redhat.com>
If not using the built-in one, don't install the headers Signed-off-by: Dave Airlie <airlied@redhat.com>
airlied
force-pushed
the
python-build-fixes
branch
from
2e4dea3
to
276306f
Compare
robquill
reviewed
May 29, 2024
| @@ -25,6 +25,7 @@ static const char* KOMPUTE_LOG_TAG = "KomputeLog"; | |||
| #else | |||
| #if KOMPUTE_BUILD_PYTHON | |||
| #include <pybind11/pybind11.h> | |||
| #include <fmt/core.h> | |||
There was a problem hiding this comment.
You could also do:
#if KOMPUTE_BUILD_PYTHON
#include <pybind11/pybind11.h>
namespace py = pybind11;
// from python/src/main.cpp
extern py::object kp_trace, kp_debug, kp_info, kp_warning, kp_error;
#endif // KOMPUTE_BUILD_PYTHON
#include <fmt/core.h>
#endif // VK_USE_PLATFORM_ANDROID_KHRAs in the code in the PR you have #include <fmt/core.h> in the #if and the #else.
|
I agree that this change is required (and works) to fix the Python build. Hopefully someone can merge this. |
|
Thank you for following up - yes this LGTM, running tests so we can merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are just a couple of fixes I found while trying to build with OS installs of some pieces.