Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I see 2 example tests in "C++ Test" action failed after merging my PR.
It was caused by
CMAKE_SOURCE_DIR
in filecmake/set_package_info.cmake
to access readme and license files. It seems ok beacuse they works almost the same asPROJECT_SOURCE_DIR
, but in example buildsCMAKE_SOURCE_DIR
points toexamples/logistic_regression
, however license and readme files are not located here.So I replaced
CMAKE_SOURCE_DIR
withPROJECT_SOURCE_DIR
to fix this.The
cpp_example
gh action is also changed.Before this, cmd line parameter
KOMPUTE_OPT_FROM_SOURCE=ON
doesn't start with a-D
prefix, so it will be ignored without any warnings and the value ofKOMPUTE_OPT_FROM_SOURCE
is still false.As a result, example builds will still access kompute from the remote master branch instead of the parent directory. I have to fix this, otherwise gh actions will always fail.