Skip to content

Commit

Permalink
Don't link pybind11 into kp_logger
Browse files Browse the repository at this point in the history
Doing so is a partial fix for building with -DKOMPUTE_OPT_BUILD_TESTS=ON
-DKOMPUTE_OPT_BUILD_PYTHON=ON but there are still undefined symbols at
link time.

Building either the tests or the Python bindings works correctly.
Building both at the same time still does not work.
  • Loading branch information
robquill committed Aug 15, 2024
1 parent 3aff5b3 commit 8651c4d
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions src/logger/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -66,10 +66,6 @@ if(NOT KOMPUTE_OPT_LOG_LEVEL_DISABLED)
else()
target_link_libraries(kp_logger PUBLIC fmt::fmt)
endif()

if(KOMPUTE_OPT_BUILD_PYTHON)
target_link_libraries(kp_logger PUBLIC pybind11::pybind11)
endif()
endif()


Expand Down

0 comments on commit 8651c4d

Please sign in to comment.