File reader changes #867
Merged
File reader changes #867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove kinc_file_reader_t::pos (use relative AAsset_seek() instead) - Make kinc_file_reader_t less Android-specific - Use the standard Unix code path when not reading an AAsset
samhocevar
force-pushed
the
patch/file-reader
branch
from
8b32666
to
32121b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file reader is now a bit less platform-specific and allows to hide platform complexity.
In the long term I believe this can be used to:
kinc_image_size_from_encoded_bytes,kinc_image_init_from_callbacksetc. or at least greatly simplify the implementation