-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/bip155 #13
Feature/bip155 #13
Conversation
when do you think we can loosen the old compiler requirements? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't do in-depth review because of failed tests but noticed incompatible upgrade of tokio/hyper.
slog-term = "2.6.0" | ||
socks = "0.3.3" | ||
tokio = { version = "0.2.22", features = ["full"] } | ||
tokio = { version = "1.0.2", features = ["full"] } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change would break MSRV 1.41.1, sorry :(
I raised an issue about this at tokio some time ago, but so far it didn't get any feedback.
e5d75c7
to
78220a0
Compare
* fix for race condition * default port to 8333 when not present * address review comments
@Kixunil - Perhaps it's time to take another look at this? The MSRV for this branch is 1.45.2, and the Rust version included with the most recent version of Debian is 1.48, so we're now comfortably passing that particular requirement. We've been running this branch in production for about a year and it works great. I've rebased on top of the intervening commits to master, and patched a couple of minor issues we found. I'd love to get this merged in. Let me know what else you need. Cheers! |
Sorry for late response, I've completely missed these comments. I'm going to look into it. |
This adds support for fetching blocks from v3 onion peers.