Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Outline segment group rendering #670

Merged
merged 7 commits into from
Nov 13, 2024
Merged

Outline segment group rendering #670

merged 7 commits into from
Nov 13, 2024

Conversation

PaulHax
Copy link
Collaborator

@PaulHax PaulHax commented Oct 21, 2024 •
edited
Loading

image

@netlify Netlify
Copy link

netlify bot commented Oct 21, 2024 •
edited
Loading

✅ Deploy Preview for volview-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit c54adc3
🔍 Latest deploy log https://app.netlify.com/sites/volview-dev/deploys/6734b5a764435d0008f3def8
😎 Deploy Preview https://deploy-preview-670--volview-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

This was referenced Oct 21, 2024
Closed
Open
Merged
@PaulHax PaulHax force-pushed the seg-outline branch 4 times, most recently from 13ea158 to 9dc71a6 Compare October 25, 2024 00:17
@PaulHax PaulHax changed the title Outline rendering attempt Outline segment group rendering Oct 29, 2024
@PaulHax PaulHax force-pushed the seg-outline branch 2 times, most recently from 46c4d92 to b255b0c Compare November 7, 2024 16:58
@PaulHax PaulHax marked this pull request as ready for review November 7, 2024 17:42
@PaulHax PaulHax linked an issue Nov 7, 2024 that may be closed by this pull request
Segment Group Stroke and Fill rendering #650
Closed
4 tasks
@PaulHax PaulHax requested a review from floryst November 7, 2024 18:41
@PaulHax
Copy link
Collaborator Author

PaulHax commented Nov 7, 2024 •
edited
Loading

Looks like this vtk.js commit broke label map rendering when the labelmap image is Int16Array (and outline rendering is on).

Kitware/vtk-js@b04e59d#diff-18c5d83bebc14325d84e520000b95e06dadffa088fe27eef138af64744171b89R1891

Guess non 8 bit was never supported, but outline rendering sort of worked with 16 bit before that commit.

@PaulHax PaulHax marked this pull request as draft November 7, 2024 21:45
@PaulHax PaulHax marked this pull request as ready for review November 7, 2024 22:33
@PaulHax
Copy link
Collaborator Author

PaulHax commented Nov 11, 2024

@floryst This is good for review now.

@floryst
Copy link
Collaborator

floryst commented Nov 12, 2024

I'm wondering if we should move some of the opacity sliders to a menu. For instance, the segment opacity slider could be moved into the edit box.

@PaulHax
Copy link
Collaborator Author

PaulHax commented Nov 12, 2024 •
edited
Loading

I'm wondering if we should move some of the opacity sliders to a menu. For instance, the segment opacity slider could be moved into the edit box.

Maybe a yes, and, for that. Slicer segmentations opacity controls:

image

@PaulHax
Copy link
Collaborator Author

PaulHax commented Nov 12, 2024

I moved the individual segment opacity slider to the edit dialog.

floryst
floryst approved these changes Nov 13, 2024
View reviewed changes
Copy link
Collaborator

@floryst floryst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@PaulHax PaulHax added this pull request to the merge queue Nov 13, 2024
Merged via the queue into Kitware:main with commit 0021740 Nov 13, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floryst floryst floryst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Segment Group Stroke and Fill rendering
2 participants
@PaulHax @floryst