gpu: Fix static array checking #8937
Conversation
|
CI Vulkan-ValidationLayers build queued with queue ID 312046. |
|
CI Vulkan-ValidationLayers build # 18150 running. |
|
CI Vulkan-ValidationLayers build # 18150 failed. |
|
CI Vulkan-ValidationLayers build queued with queue ID 312603. |
|
CI Vulkan-ValidationLayers build # 18154 running. |
|
CI Vulkan-ValidationLayers build # 18154 failed. |
|
CI Vulkan-ValidationLayers build queued with queue ID 312677. |
|
CI Vulkan-ValidationLayers build # 18158 running. |
|
CI Vulkan-ValidationLayers build # 18158 passed. |
spencer-lunarg
force-pushed
the
spencer-lunarg-arrays-are-fun
branch
from
5eccea6
to
76fc7ce
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 314115. |
|
CI Vulkan-ValidationLayers build # 18166 running. |
|
CI Vulkan-ValidationLayers build # 18166 passed. |
spencer-lunarg
force-pushed
the
spencer-lunarg-arrays-are-fun
branch
from
76fc7ce
to
464ffce
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 314386. |
|
CI Vulkan-ValidationLayers build # 18168 running. |
|
CI Vulkan-ValidationLayers build # 18168 failed. |
|
CI Vulkan-ValidationLayers build queued with queue ID 314441. |
|
CI Vulkan-ValidationLayers build # 18169 running. |
|
CI Vulkan-ValidationLayers build # 18169 passed. |
| return false; | ||
| } | ||
|
|
||
| if (pointer_type->inst_.IsArray() && access_chain_inst->Length() >= 5) { |
There was a problem hiding this comment.
Some comment on this 5 maybe?
| return false; | ||
| } | ||
|
|
||
| const Variable* variable = module_.type_manager_.FindVariableById(access_chain_inst_->Operand(0)); | ||
| const Variable* variable = module_.type_manager_.FindVariableById(access_chain_inst->Operand(0)); | ||
| if (!variable) { | ||
| return false; | ||
| } | ||
| var_inst_ = &variable->inst_; | ||
|
|
||
| uint32_t storage_class = variable->StorageClass(); |
There was a problem hiding this comment.
| uint32_t storage_class = variable->StorageClass(); | |
| const uint32_t storage_class = variable->StorageClass(); |
closes #6944
Now that GPU-AV is in a better shape, was able to actually try and re-work this logic. Tests added and re-enabled to confirm things work as expected (still some open edge cases, but will be worked out after getting some spec clarification)