scripts: Split up chasssis.{h,cpp} #8904
Conversation
|
CI Vulkan-ValidationLayers build queued with queue ID 307711. |
|
CI Vulkan-ValidationLayers build # 18094 running. |
|
CI Vulkan-ValidationLayers build # 18094 failed. |
jeremyg-lunarg
force-pushed
the
jeremyg-dispatch-2
branch
from
4043689
to
60f5108
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 307738. |
|
CI Vulkan-ValidationLayers build # 18095 running. |
jeremyg-lunarg
force-pushed
the
jeremyg-dispatch-2
branch
from
60f5108
to
8060026
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 307754. |
|
CI Vulkan-ValidationLayers build # 18096 running. |
|
CI Vulkan-ValidationLayers build # 18096 failed. |
There was a problem hiding this comment.
LGTM (assuming things are just copy-and-pasted where I expect it to be)
Did a double check locally and seems things are split up well, of course will want @aqnuep sign off as well as someone who will have to ingest this downstream
| @@ -21,7 +21,6 @@ | |||
|
|
|||
| #include <vulkan/vk_enum_string_helper.h> | |||
| #include "error_message/error_location.h" | |||
| #include "generated/chassis.h" | |||
There was a problem hiding this comment.
not having to whole-include the chassis here makes me happy
| wrap_handles = false; | ||
| } | ||
|
|
||
| // Add VOs to dispatch vector. Order here will be the validation dispatch order! |
There was a problem hiding this comment.
This part needs to go back to generated code because it is different for SC
| // Note that this DEFINES THE ORDER IN WHICH THE LAYER VALIDATION OBJECTS ARE CALLED | ||
| disabled = instance_dispatch->disabled; | ||
| enabled = instance_dispatch->enabled; | ||
| if (!disabled[thread_safety]) { |
There was a problem hiding this comment.
This part needs to go back to generated code because it is different for SC
| bool &is_secondary) { | ||
| { | ||
| auto lock = ReadLockGuard(secondary_cb_map_mutex); | ||
| is_secondary = secondary_cb_map.find(commandBuffer) != secondary_cb_map.end(); |
There was a problem hiding this comment.
secondary command buffer tracking was happening in chassis.cpp. It is needed here for handle wrapping weirdness. Unfortunately, thread safety and object tracking were relying on is_secondary as well so I had to hack to pass it back out of this method :(
There was a problem hiding this comment.
this is because VkCommandBufferBeginInfo::pInheritanceInfo can be a garbage pointer, we need to ignore it (including Safe Struct) if it is not a secondary pointer
Going to create an issue if we can require this to be null as the app really should clear it out and not require everyone to state track to know if we can deference it or not
There was a problem hiding this comment.
The files under layers/chassis and scripts/generators need the most review IMO. But that can wait until I clean up the epic fails I'm getting in CI |
jeremyg-lunarg
force-pushed
the
jeremyg-dispatch-2
branch
5 times, most recently
from
3e68248
to
6fbaa52
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 309130. |
|
CI Vulkan-ValidationLayers build # 18117 running. |
|
CI Vulkan-ValidationLayers build # 18117 failed. |
Move the giant blocks of 'manual' code to files under layers/chassis DispatchObject and ValidationObject are a big mix of manual and generated code. The class definition headers #include a file defining generated methods. chassis.h is now a manual file that only defines some shared data structures and the manual defined functions needed by the generated code.
jeremyg-lunarg
force-pushed
the
jeremyg-dispatch-2
branch
from
6fbaa52
to
cdb1f8f
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 309181. |
|
CI Vulkan-ValidationLayers build # 18118 running. |
|
CI Vulkan-ValidationLayers build # 18118 passed. |
Move the giant blocks of 'manual' code to files under layers/chassis
DispatchObject and ValidationObject are a big mix of manual and generated code. The class definition headers #include a file defining generated methods.
chassis.h is now a manual file that only defines some shared data structures and the manual defined functions needed by the generated code.