[DebugInfo] Support translation of DIStringType #1877
Merged
+241
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This type instruction describes a string, mostly for Fortran 90. Spec: KhronosGroup/SPIRV-Registry#186
MrSidims
reviewed
Mar 9, 2023
MrSidims
reviewed
Mar 9, 2023
lib/SPIRV/LLVMToSPIRVDbgTran.cpp
Outdated
Comment on lines
766
to
769
| if (ST->getRawStringLengthExp()) { | ||
| Ops[LengthAddrIdx] = TransOperand(ST->getRawStringLengthExp()); | ||
| } else if (ST->getRawStringLength()) { | ||
| Ops[LengthAddrIdx] = TransOperand(ST->getRawStringLength()); |
There was a problem hiding this comment.
Suggested change
| if (ST->getRawStringLengthExp()) { | |
| Ops[LengthAddrIdx] = TransOperand(ST->getRawStringLengthExp()); | |
| } else if (ST->getRawStringLength()) { | |
| Ops[LengthAddrIdx] = TransOperand(ST->getRawStringLength()); | |
| if (const auto *LenExp = ST->getRawStringLengthExp()) { | |
| Ops[LengthAddrIdx] = TransOperand(LenExp); | |
| } else if (const auto *Len = ST->getRawStringLength()) { | |
| Ops[LengthAddrIdx] = TransOperand(Len); |
MrSidims
approved these changes
Mar 10, 2023
aratajew
pushed a commit
to aratajew/SPIRV-LLVM-Translator
that referenced
this pull request
Mar 29, 2023
This type instruction describes a string, mostly for Fortran 90. Spec: KhronosGroup/SPIRV-Registry#186
stanleygambarin
pushed a commit
to stanleygambarin/SPIRV-LLVM-Translator
that referenced
this pull request
Mar 30, 2023
…nosGroup#1877) This type instruction describes a string, mostly for Fortran 90. Spec: KhronosGroup/SPIRV-Registry#186
stanleygambarin
pushed a commit
to stanleygambarin/SPIRV-LLVM-Translator
that referenced
this pull request
Mar 30, 2023
…nosGroup#1877) This type instruction describes a string, mostly for Fortran 90. Spec: KhronosGroup/SPIRV-Registry#186
MrSidims
pushed a commit
that referenced
this pull request
Mar 31, 2023
This type instruction describes a string, mostly for Fortran 90. Spec: KhronosGroup/SPIRV-Registry#186
MrSidims
pushed a commit
that referenced
this pull request
Apr 3, 2023
This type instruction describes a string, mostly for Fortran 90. Spec: KhronosGroup/SPIRV-Registry#186
mateuszchudyk
pushed a commit
to mateuszchudyk/SPIRV-LLVM-Translator
that referenced
this pull request
May 10, 2023
…nosGroup#1877) This type instruction describes a string, mostly for Fortran 90. Spec: KhronosGroup/SPIRV-Registry#186
mateuszchudyk
pushed a commit
to mateuszchudyk/SPIRV-LLVM-Translator
that referenced
this pull request
Sep 29, 2023
…nosGroup#1877) This type instruction describes a string, mostly for Fortran 90. Spec: KhronosGroup/SPIRV-Registry#186
MrSidims
pushed a commit
that referenced
this pull request
Oct 5, 2023
This type instruction describes a string, mostly for Fortran 90. Spec: KhronosGroup/SPIRV-Registry#186
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This type instruction describes a string, mostly for Fortran 90.
Spec:
KhronosGroup/SPIRV-Registry#186