Migrate expression widget to latest version in PerseusItem parser #1908
+172
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benchristel
requested review from
anakaren-rojas,
catandthemachines,
jeremywiebe and
nishasy
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (44fc32c) and published it to npm. You Example: yarn add @khanacademy/perseus@PR1908If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR1908 |
|
Size Change: +261 B (+0.02%) Total Size: 1.29 MB
ℹ️ View Unchanged
|
jeremywiebe
approved these changes
Nov 25, 2024
| } | ||
|
|
||
| export const parseExpressionWidget: Parser<ExpressionWidget> = | ||
| union(pipeParsers(parseExpressionWidgetV0).then(migrateV0ToLatest).parser) |
There was a problem hiding this comment.
So this will attempt to parse using the v0 and migration parsers and fall back to the parseExpressionWidgetLatest if that fails, right?
This might be extremely over-the-top optimization, but I wonder if we should order these in the opposite order given we'll more likely get a latest version set of options rather than v0 options? 🤔
benchristel
changed the title
benchristel
force-pushed
the
benc/parser-regression-tests-1
branch
from
d6697a2
to
b0ed10b
Compare
benchristel
changed the base branch from
benc/parser-regression-tests-1
to
main
benchristel
force-pushed
the
benc/expression-widget-migration
branch
from
f85fe16
to
0e29951
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This demonstrates how we can upgrade/migrate widget options in the parsing
code, obviating the need for
propUpgrades.The fact that
versionis an object makes this really annoying becauseTypeScript can't discriminate unions based on nested properties like
version.major. Given that constraint, I think the approach I came up with isreasonable, but I'm certainly open to feedback on how to improve it.
Issue: LEMS-2582
Test plan:
yarn test