refactor: clubMember.size() -> countByClubClubTokenAndDeletedFalse 로 변경 #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soeunnPark
approved these changes
Nov 22, 2024
| @@ -37,6 +37,8 @@ public interface ClubMemberService { | |||
|
|
|||
| void deleteAllClubMembers(String clubToken); | |||
|
|
|||
| Integer countByClubClubTokenAndDeletedFalse(String clubToken); | |||
There was a problem hiding this comment.
repository에 있는 메서드명이랑 동일하게 사용하기보다는 목적을 드러내는 메서드명이 어떨까요?
예를 들어, countExistingClub 등이 어떨까요? By~ 로 어떤 파라미터가 전달되는지 메서드명에 적게 되면, 의미가 중복되는 것 같아요. 뒤에 있는 String clubToken 파라미터 만으로도 어떤 것으로 조회를 하는지 알 수 있으니까요
| @@ -148,6 +148,11 @@ public void deleteAllClubMembers(String clubToken) { | |||
| }); | |||
| } | |||
|
|
|||
| @Override | |||
| public Integer countByClubClubTokenAndDeletedFalse(String clubToken) { | |||
| return clubMemberReader.getClubMemberCountsByClubToken(clubToken); | |||
There was a problem hiding this comment.
Count는 불가산명사라서 뒤에 s를 붙일 필요 없어요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR에 대한 설명 🔍
#435 (comment)