Feat/calendar component initial #1
Conversation
bkapustik
requested review from
michalJakubis and
MartinK-Kentico
and removed request for
michalJakubis
|
Can you please provide more info to this PR within description? What is this initial PR about? What is complete? What is missing and needs to be added in subsequent PR? |
|
Also please replace or remove all references to Kentico.Xperience.RepoTemplate and check that tasks in .vscode folder works as expected. |
bkapustik
requested review from
michalJakubis
and removed request for
MartinK-Kentico
Directory.Packages.props
Outdated
| <PackageVersion Include="SonarAnalyzer.CSharp" Version="9.23.0.88079" /> | ||
| <PackageVersion Include="Microsoft.Extensions.Logging.Debug" Version="3.1.8" /> |
There was a problem hiding this comment.
Please fix indentation
Directory.Build.props
Outdated
|
|
||
| <EnableDefaultEmbeddedResourceItems>false</EnableDefaultEmbeddedResourceItems> | ||
| <TimestampServerUrl>http://timestamp.digicert.com</TimestampServerUrl> | ||
| <NoWarn>$(NoWarn);1591;S3267</NoWarn> |
There was a problem hiding this comment.
Please fix indentation
.vscode/launch.json
Outdated
| @@ -9,9 +9,9 @@ | |||
| "type": "coreclr", | |||
| "request": "launch", | |||
| "preLaunchTask": "build", | |||
| "program": "${workspaceFolder}/src/Kentico.Xperience.RepoTemplate.Sample/bin/Debug/net6.0/DancingGoat.dll", | |||
| "program": "${workspaceFolder}/src/Kentico.Xperience.CalendarComponent.Sample/bin/Debug/net6.0/DancingGoat.dll", | |||
There was a problem hiding this comment.
This path does not seem to be correct, there is no Sample project. Can you make sure that this task is working as expected?
.vscode/tasks.json
Outdated
| @@ -71,7 +71,7 @@ | |||
| "watch", | |||
| "run", | |||
| "--project", | |||
| "${workspaceFolder}/src/Kentico.Xperience.RepoTemplate.Sample/DancingGoat.csproj" | |||
| "${workspaceFolder}/src/Kentico.Xperience.CalendarComponent.Sample/DancingGoat.csproj" | |||
There was a problem hiding this comment.
The same issue as above.
| @@ -0,0 +1,33 @@ | |||
| { | |||
| "name": "ktc-calendarComponent", | |||
There was a problem hiding this comment.
@kentico/xperience-calendar-component
There was a problem hiding this comment.
The name of this file is no longer valid. The package should be called xperience-calendar-component. We need to rebuild Client package with correct name set in webpack config and include the latest one with correct name.
| @@ -7,7 +7,7 @@ const config = { | |||
| entry: "./src/index.js", | |||
| output: { | |||
| path: path.resolve(__dirname, ".././wwwroot/js"), | |||
| filename: "ktc-calendarComponent.js", | |||
| filename: "@kentico/xperience-calendar-component.js", | |||
There was a problem hiding this comment.
The file name should be just xperience-calendar-component.js. This is how we name the package file names in XbK. We omit the kentico prefix.
| Label = "Date Format", | ||
| DefaultValue = "m.d.Y", | ||
| ExplanationText = "Select Date format", | ||
| Order = 5)] |
There was a problem hiding this comment.
The order parameters seem to be a bit inconsistent. They are not incrementing predictably, and property bellow does not set Order at all. This can lead to an unexpected order of components in final result.
| <FrameworkReference Include="Microsoft.AspNetCore.App" /> | ||
| </ItemGroup> | ||
| <ItemGroup> | ||
| <Folder Include="wwwroot\js\" /> |
There was a problem hiding this comment.
Indentation in this file is inconsistent.
| /// Returns data from dynamic data provider for a given calendar form component. | ||
| /// </summary> | ||
| /// <param name="dataProviderName">name of the provider</param> | ||
| /// <returns></returns> |
There was a problem hiding this comment.
Empty returns description.
Motivation
Calendar form component integration enabling to add a calendar form component. This integration allows for choice between seelcting a date, date and time or range of days, or multiple days. In addition it allows for simple programatic exclusion of excluded date and time values.