Membership/fb - Add Membership functionality (live site users) to the repository #88

kentico-matthews · 2024-11-13T13:54:17Z

Motivation

Demonstrate membership functionality

…by-kentico-quickstart-guides into Membership/FB

…rvice, extend the MemberInfo class to reflect custom fields

…Info field name

… controllers.

…auth check to registration view component

…by-kentico-quickstart-guides into Membership/FB

…fix button issue in sign out widget

…wards work

…ignOut to Sign in page; render LinkOrSignOut widget in the header (TODO: retrieve the Sign in page. For now it only shows up if user is authenticated)

…add signed-in status check before rendering registration form

…s on member class

…, add tests

… same contact does not get associated with a different member if someone else logs in in the same browser session

…by-kentico-quickstart-guides into Membership/FB

…gned in yet

… a different approach

…tried to access after successfully signing in

…by-kentico-quickstart-guides into Membership/FB

src/TrainingGuides.Web/ComponentIdentifiers.cs

src/TrainingGuides.Web/Features/Membership/Controllers/AuthenticationController.cs

src/TrainingGuides.Web/Features/Membership/Controllers/RegistrationController.cs

kentico-matthews · 2024-11-19T21:39:34Z

src/TrainingGuides.Web/Features/Membership/Controllers/RegistrationController.cs

+        },
+        Request.Scheme) ?? string.Empty;
+
+        await emailService.SendEmail(new EmailMessage()


Once you've confirmed that the preferred language is in context, you can add a localizer to the text of these email fields

src/TrainingGuides.Web/Features/Membership/Controllers/RegistrationController.cs

src/TrainingGuides.Web/Features/Membership/Services/MembershipService.cs

kentico-matthews · 2024-11-20T16:41:49Z

src/TrainingGuides.Web/Features/Membership/Widgets/Registration/EmailConfirmation.cshtml

+                                    case EmailConfirmationState.FailureConfirmationFailed:
+                                        <h4 test-id="confirmationMessage" class="text-center k-dot">@Model.Message</h4>
+
+                                        <form id="resendVerificationForm" method="post" asp-controller="Registration" asp-action="ResendVerificationEmail">


As it is now, the only way for them to resent the confirmation email is to follow the link in the first email
Should we include some kind of path for when a registrant loses the first email?

src/TrainingGuides.Web/Features/Membership/Widgets/Registration/RegistrationWidgetProperties.cs

src/TrainingGuides.Web/Features/Shared/Services/ContentItemRetrieverService.cs

…r secured articles

…e new column

… in article page service

dominikag2 · 2024-11-19T21:06:08Z

src/TrainingGuides.Web/Features/Membership/Services/MemberContactService.cs

+        }
+        if (!string.IsNullOrWhiteSpace(guidesMember.FavoriteCoffee))
+        {
+            _ = newContact.SetValue("TrainingGuidesContactFavoriteCoffee", guidesMember.FavoriteCoffee);


I would vote for making the "TrainingGuidesContactFavoriteCoffee" and the "TrainingGuidesContactMemberId" constants somewhere. "TrainingGuidesContactMemberId" is being used twice, so it makes a lot of sense to prevent stupid typo errors in the future. And to me it will read easier if the favorite coffee is consistent with that.

dominikag2 · 2024-11-26T13:05:48Z

src/TrainingGuides.Web/Features/Membership/Controllers/RegistrationController.cs

+
+namespace TrainingGuides.Web.Features.Membership.Controllers;
+
+public class RegistrationController(


I noticed, that we are using two different ways of assigning the private readonly properties - when you compare this controllers with the others. E.g., Authentication or Cookies. Do you think it's worth it to make it consistent?

…mit with the accidentally empty message)

…by-kentico-quickstart-guides into Membership/FB

kentico-matthews and others added 30 commits November 7, 2024 11:39

GH-86 :: Create registration widget directory

02a8f9a

GH-86 :: begin progress implementing registration

f3bdd3f

GH-86 :: fix spelling in widget properties

4a6d75c

GH-86 :: progress

8f10415

GH-86 :: registration widget progress

cc13708

GH-89 :: add membership service - menat to handle all user manager stuff

a65c2e7

GH-89 :: sign in widget WIP

ce2b417

GH-86 :: updates to registration server-side form validation

ac553aa

Merge branch 'Membership/FB' of https://github.com/Kentico/xperience-…

b762bf4

…by-kentico-quickstart-guides into Membership/FB

GH-86 :: move UserManager code for registration into the MambershipSe…

3e80516

…rvice, extend the MemberInfo class to reflect custom fields

GH-86 :: fix label in registration form

8c849ea

GH-86 :: add title to registration form and fix typo in custom Member…

092a426

…Info field name

GH-89 :: sign in widget WIP, relocate Authentication and registration…

a4f86b6

… controllers.

GH-86 :: add link/sign out widget, move registration controller, add …

b70af57

…auth check to registration view component

Merge branch 'Membership/FB' of https://github.com/Kentico/xperience-…

dea7c4d

…by-kentico-quickstart-guides into Membership/FB

GH-89 :: extract sign in logic into the Membership service

86c1ef6

GH-86 :: add sign out functionality

0074b13

GH-86 :: add widget configuration validation

0519b6d

GH-86 :: add registration page, enable non-required strings in form, …

21869a8

…fix button issue in sign out widget

GH-89 :: sign in form signs you in, but errors nor the redirect after…

b53ef0c

…wards work

GH-89 :: fix error rendering for sing-in

53548cb

GH-89 :: fix sign in button formatting in Sign in widget; Add LinkOrS…

cc962e4

…ignOut to Sign in page; render LinkOrSignOut widget in the header (TODO: retrieve the Sign in page. For now it only shows up if user is authenticated)

GH-89 :: UI improvements

cfd2bd6

GH-86 :: adjust form target and controller action name for sign out, …

e439654

…add signed-in status check before rendering registration form

GH-89 :: add contact mapping for membership, update custom field name…

8709d61

…s on member class

GH-89 :: redirecting after successful sign in.

b173135

GH-89 :: redirect page after sign in - let user pick is in the widget…

72bd1b2

…, add tests

GH-89 :: set code to remove cookies when the member signs out, so the…

f05d5a3

… same contact does not get associated with a different member if someone else logs in in the same browser session

Merge branch 'Membership/FB' of https://github.com/Kentico/xperience-…

bf20129

…by-kentico-quickstart-guides into Membership/FB

GH-89 :: Navigate to sign in page from button in the header if not si…

512b35b

…gned in yet

dominikag2 and others added 7 commits November 19, 2024 10:58

GH-89 :: sign in redirect - WIP

c0d78b1

GH-89 :: remove authentication scripts - not needed anymore, we chose…

297606f

… a different approach

GH-90 :: Add functionality to return member to the secured page they …

a2656f2

…tried to access after successfully signing in

Merge branch 'Membership/FB' of https://github.com/Kentico/xperience-…

1846652

…by-kentico-quickstart-guides into Membership/FB

GH-90 :: add summary for new service method

339ca06

GH-87 :: add membership service documentation

dd42d36

Merge branch 'Membership/FB' of https://github.com/Kentico/xperience-…

f3660ab

…by-kentico-quickstart-guides into Membership/FB

kentico-matthews commented Nov 19, 2024

View reviewed changes

GH-86 :: Fix localization in registration action

d0738fa

kentico-matthews commented Nov 20, 2024

View reviewed changes

kentico-matthews added 9 commits November 20, 2024 12:54

GH-90 :: Add language checks when redirecting 403 to sign in page

e8fe880

GH-89 :: Merge contacts when signing in

351603b

GH-90 :: Add functionality to hide or prompt login in listing page fo…

30f93fb

…r secured articles

GH-90 :: adjust widget configuration on widget samples page to includ…

ee349d6

…e new column

GH-69 :: fix missing page urls for spanish in articles

e46ea8d

GH-69 :: Fix spanish URL paths for CI copied articles

bb55829

GH-90 :: Add secured checks to content querying, adjust url retrieval…

8d36270

… in article page service

GH-90 :: add translations, small refactor on sign in prompt

a4c4e50

GH-92 :: initial code for reset password functionality,

53e3e56

dominikag2 reviewed Nov 26, 2024

View reviewed changes

kentico-matthews and others added 9 commits November 26, 2024 11:27

GH-92 :: improvements to localization of reset password functionality

9a71075

GH-93 :: initial progress on profile page

31d6a0f

no message

1a609ce

GH-87 :: implement review suggestions (together with the previous com…

dcfbd38

…mit with the accidentally empty message)

GH-91 :: implement review suggestions - fix multilingual URLs

91f4e23

GH-93 :: Continue progress on profile page

f799c82

GH-93 :: register UpdateProfileService with DI

61f2fb7

Merge branch 'Membership/FB' of https://github.com/Kentico/xperience-…

1cb5ea9

…by-kentico-quickstart-guides into Membership/FB

GH-93 :: add localization, rearrange pages, small refactors

b6859ad

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Membership/fb - Add Membership functionality (live site users) to the repository #88

Membership/fb - Add Membership functionality (live site users) to the repository #88

kentico-matthews commented Nov 13, 2024

kentico-matthews Nov 19, 2024

kentico-matthews Nov 20, 2024

dominikag2 Nov 19, 2024

dominikag2 Nov 26, 2024


		namespace TrainingGuides.Web.Features.Membership.Controllers;

		public class RegistrationController(

Membership/fb - Add Membership functionality (live site users) to the repository #88

Are you sure you want to change the base?

Membership/fb - Add Membership functionality (live site users) to the repository #88

Conversation

kentico-matthews commented Nov 13, 2024

Motivation

kentico-matthews Nov 19, 2024

Choose a reason for hiding this comment

kentico-matthews Nov 20, 2024

Choose a reason for hiding this comment

dominikag2 Nov 19, 2024

Choose a reason for hiding this comment

dominikag2 Nov 26, 2024

Choose a reason for hiding this comment