Fixes #36649 - Remove katello-agent out of legacy UI

[chris1984]

Will fill this out when I get the tests green, pushing up to see the mess that I caused. Locally there is like 13 failures.

What are the changes introduced in this pull request?

Considerations taken when implementing this change?

What are the testing steps for this pull request?

Todo:

• Put back rex in carrot menu
• (Update performDefaultUpdateAction function name)
• (Remove bulk errata kagent stuff)
• (Fix Tests after fixing last 2 items)

[theforeman-bot]

Issues: #36649

[jeremylenz]

Some initial code comments :)

[jeremylenz]

Seems like a few Katello tests need updates.

[chris1984]

Seems like a few Katello tests need updates.

@jeremylenz Was it because I changed them from a katello agent task to a rex job? Or is there something else that caused them to fail?

[jeremylenz]

Was it because I changed them from a katello agent task to a rex job? Or is there something else that caused them to fail?

[2023-08-14T21:18:00.120Z] Failure:

[2023-08-14T21:18:00.120Z] Katello::Api::V2::ContentViewVersionsControllerTest#test_incremental_update [/home/jenkins/workspace/katello-pr-test/test/controllers/api/v2/content_view_versions_controller_test.rb:270]

[2023-08-14T21:18:00.120Z] Minitest::Assertion: Expected response to be a <2XX: success>, but was a <500: Internal Server Error>

[2023-08-14T21:18:00.120Z] 

[2023-08-14T21:18:00.120Z] Failure:

[2023-08-14T21:18:00.120Z] Katello::Api::V2::ContentViewVersionsControllerTest#test_incremental_update_with_deb [/home/jenkins/workspace/katello-pr-test/test/controllers/api/v2/content_view_versions_controller_test.rb:283]

[2023-08-14T21:18:00.120Z] Minitest::Assertion: Expected response to be a <2XX: success>, but was a <500: Internal Server Error>

[2023-08-14T21:18:00.120Z] 

[2023-08-14T21:18:00.120Z] Failure:

[2023-08-14T21:18:00.120Z] Katello::Api::V2::ContentViewVersionsControllerTest#test_incremental_update_without_env [/home/jenkins/workspace/katello-pr-test/test/controllers/api/v2/content_view_versions_controller_test.rb:295]

[2023-08-14T21:18:00.120Z] Minitest::Assertion: Expected response to be a <2XX: success>, but was a <500: Internal Server Error>

Looks like the test failures are all around incremental updates.. which I'm not sure is related. We don't know for sure, though, because we don't have the error stack from test.log that would tell us why we got the 500s. Let's run it again and see if it was a fluke.

[jeremylenz]

[test katello]

[jeremylenz]

@chris1984 Same three failures. Can you run those tests locally and look at log/test.log to see why it's sending 500s?

[chris1984]

@jeremylenz finally green :) Ready for testing and a 2nd review. Once you merge your REX setting removal PR, I will have to rebase this one, but it should be good to test/review at least

[jeremylenz]

Once you merge your REX setting removal PR, I will have to rebase this one

Should be no need, since I plan to merge this one first :)

[jeremylenz]

Found one straggler:

katello/engines/bastion_katello/test/content-hosts/content/content-host-packages-applicable.controller.test.js

Line 40 in 05b73f7

$scope.performViaKatelloAgent = function() {};

Otherwise LGTM!

[chris1984]

@jeremylenz updated and removed the straggler, let me know how this looks

[chris1984]

[test katello]

[chris1984]

Damn vcr failures

[chris1984]

[test katello]

[jeremylenz]

ACK 👍

test failures unrelated