-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add packit config #10566
add packit config #10566
Conversation
seems someone (@ehelms?) gotta approve the org in Packit first -.- |
/packit build |
That built, but uses a version that will "always" higher than nightly, not sure I like it |
stupid pre-release gems, I couldn't fix it without doing almost everything packit does manually, so, uh, let's not :) |
What is it that packit is doing that we don't have control over? As we onboard more plugins as nightly projects, we are going to see this over and over. So I am left wondering if we need a fix from Packit? |
It's replacing the I found a way to make it stop, but then it's also not doing a few other changes to the spec file and that broke other stuff. I dan try having another look next week |
# downstream (Fedora) RPM package name | ||
downstream_package_name: rubygem-katello | ||
|
||
upstream_tag_template: "{version}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since I'm also trying to add packit to some project, I've got a question: is this line necessary? I mean, by https://packit.dev/docs/configuration/#upstream_tag_template it makes more sense if the tag contains something else along the version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not. It's just part of the template (as most projects/plugins use v{version}) and it felt more natural to set it "correctly" vs dropping
Hello all, Packit PO here..;) I am happy to see you are configuring Packit for more and more Foreman projects! So, let us know if there is something we can improve to make your life easier. It makes sense to make a change on our side if there is something you are fighting in every single package. Please, either create an issue or we can also set up a virtual meeting to discuss this. (If you want, we can also discuss how you can get more out of Packit...) František |
I think it now does "the right thing" when mangling around the spec file, and I've opened packit/packit#2038 and packit/packit#2040 to make those steps easier in the future. |
Where does the buildroot get specified? When we switch to Copr we will have repositories that were built against RHEL and I'd imagine we'd want to do the same across Packit? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did not mean to close this earlier, I have a later question I posted this as it stands works and is useful so I am going to merge.
The |
What are the changes introduced in this pull request?
adds support for packit (see https://community.theforeman.org/t/packit-for-foreman-get-production-rpms-from-prs/32412)
Considerations taken when implementing this change?
none
What are the testing steps for this pull request?
spin up a box
should give you a .rpm build of Katello from a PR :)