-
-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use docker metadata to generate combos of labels, tags, and images #3396
base: develop
Are you sure you want to change the base?
Conversation
Tools like renovate and dependabot use docker labels to determine where to look for changelogs Before (Especially incorrect as its not ubuntu nor 20.04, its kavita):
After
|
I'm not able to grasp, outside the fork changes, what renovate is actually doing or why it's needed. @DieselTech please shine some light as well. |
so https://docs.renovatebot.com/modules/datasource/docker/ is the docs for renovate. I'll admit i don't fully understand which labels they use, I do know the ones generated by the action work Essentially they compare the labels on previous (or latest) and current tag to get the source location (this repo) and the ref (the tag), then it can use the github releases to match release notes and include them in the PR updating an image tag (with a fallback to just diff link if no release note). I ->believe<- docker hub also will use these container labels to include links to the original repo in the sidebar, but i honestly havn't tested it. Generally the opencontainer labels (which the docker action adds by default) just is a nice convention to follow and lots of tools can use them. |
|
Okay, but I'm not sure why we need them on Kavita. I'm not understanding the value add. That's what I'm trying to grasp. |
Its like adding og: meta tags to web sites. It allows machines easier time to get metadata. In my case, I use gitops so instead of using :latest, I use a specific tag, and renovate sends me a PR to update the tag. Its nice to have renovate also include the release notes directly in the PR so I don't have to goto this repo and find the release and the release notes. I would suspect watchtower has something with docker labels too, i saw a dependancy, but i couldn't find where it might actually read it. Just nice to have for consumers, it shouldn't affect kavita directly at all. |
Changed