Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare Release v0.3.0 #2

Merged
merged 143 commits into from
Mar 29, 2024
Merged

Prepare Release v0.3.0 #2

merged 143 commits into from
Mar 29, 2024

Conversation

hsonne
Copy link
Member

@hsonne hsonne commented Jul 1, 2022 •
edited by mrustl
Loading

This change is Reviewable

hsonne added 30 commits June 30, 2022 23:51
@hsonne
Update Rd files
f954a80
@hsonne
Use non-deprecated function
a9b3062
@hsonne
Cosmetics, let if () set variable to NULL
9ec7eca
@hsonne
Add new version of getInspectionHeaderInfo()
75ba017 
using kwb.utils::extractSubstring()
@hsonne
Extract readObservationsFromCsvText()
a1087da
@hsonne
Use new function to get read inspection headers
9702b3f
@hsonne
Use new function to read observation data
9bcf146 
if the original function getObservationsFromEuLines() fails
@hsonne
Use kwb.utils::isTryError()
fec0fbc
@hsonne
Add arg "dbg" to getInspectionsFromEuLines()
320ce55
@hsonne
Check and adapt arg "colClasses" if given
73df1d5
@hsonne
Set "colClasses" according to expected types
32ed19b
@hsonne
Remove empty records from table of observations
2ef0fad
@hsonne
Update NAMESPACE and Roxygen version
53ed267
@hsonne
Add last "to" position if there is not last #Z
5f69a14
@hsonne
Add getLineDamageInfo() from kwb.rerau
10cb238 
also add related helper functions and tests
@hsonne
Use kwb.utils::orderBy(), renumbering rows
a19a84f
@hsonne
Rename file according to contained function
538b5e1
@hsonne
Reindent to improve readability
c5582c6
@hsonne
Update Rd files (consider file renaming)
bb531bb
@hsonne
Clean readAndMergeEuCodedFiles()
9e0abca 
- Use "L" to indicate integer constant
- Do not use intermediate varialbes
  "header_info", "inspections_all",
  "observations_all"
- Use lapply() instead of for-loop
- Use variable name "obs" to shorten lines
@hsonne
Add simple test for mergeInspectionData()
b22b2c4
@hsonne
Return early in asNumericIfRequired()
133416d
@hsonne
Improve output of warnOnDifferingHeaders()
523e95a 
by using "drop = FALSE" and add simple test
@hsonne
Allow "table" to be a vector of table names
3c1dba4 
Stop with error message if table name does
not exist
@hsonne
Simplify get_code_meanings()
fab53b3 
and let getCodes() renumber the rows
@hsonne
Simply use writeLines()
f38b650
@hsonne
Move functions from main.R to utils.R
26e98f0
@hsonne
Use "L" to indicate integer constant
12756fb
@hsonne
Move removeEmptyLines() to utils.R
c06aaa2
@hsonne
Reindent
e09f59a
@hsonne
Simplify error message (may have been confusing)
51c819c
@hsonne
Invert logic, use "result" as variable name
edd32d3
@hsonne
Allow to write duplicates to a file
d232432
@hsonne
Import capture.output()
2ee4a2c
@hsonne
Add argument "error.file", rename from "file"
f3b82bb
@hsonne
Add argument "naToEmpty"
ba33205
@hsonne
Allow to specify the file encoding
445cf13
@hsonne
Rename getFileEncoding()
dae5c73 
to readFileEncodingFromHeader() and check
"file.encoding" for allowed string values
@hsonne
Change default of "encoding" to "unknown"
a5df320
@hsonne
Replace encoding iso-8859-1:1998 with latin1
198bef1 
and add argument "check.encoding"
@hsonne
Add latest change as NEWS entry
4f5a0ca
@hsonne
Replace also "ISO-8859-1" with "latin1"
6b4575c
@hsonne
Accept "latin1" as encoding string
c1f33c5
@hsonne
Use "L" to indicate "integer" (long)
83294a2
@hsonne
Add Roxygen export directives
4ab30eb
@hsonne
Use kwb.utils::collapsed()
078d23d
@hsonne
Use normal output instead of message
fd6ef99
@hsonne
Update NAMESPACE
f3c8c13
@hsonne
Try to find out why GitHub Actions fail
ea7df69
@hsonne
Try harder
f417055
@hsonne
Using kwb.utils >= v0.15.0 should have fixed it
d61b6fa
@hsonne hsonne changed the title Dev Prepare new Release Mar 28, 2024
@hsonne hsonne changed the title Prepare new Release Prepare new Release v0.3.0 Mar 28, 2024
@hsonne hsonne changed the title Prepare new Release v0.3.0 Prepare Release v0.3.0 Mar 28, 2024
@hsonne hsonne merged commit b4f6981 into master Mar 29, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hsonne