feat/change-serach-to-get-request (#129)

* change controller action to be get request instead of post * move search form markup to a partial view
JwanKhalaf · Dec 27, 2023 · 7de48a6 · 7de48a6
1 parent d7a86b9
commit 7de48a6
Show file tree

Hide file tree

Showing 8 changed files with 16 additions and 34 deletions.
diff --git a/Bejebeje.Mvc/Controllers/SearchController.cs b/Bejebeje.Mvc/Controllers/SearchController.cs
@@ -27,14 +27,14 @@ public IActionResult Index()
       return View(viewModel);
     }
 
-    [HttpPost]
-    public async Task<IActionResult> Index(string searchTerm)
+    [HttpGet]
+    public async Task<IActionResult> Search(string searchTerm)
     {
       SearchViewModel viewModel = new SearchViewModel();
 
       if (string.IsNullOrEmpty(searchTerm))
       {
-        return View(viewModel);
+        return View("Index", viewModel);
       }
 
       viewModel.SearchTerm = searchTerm;
@@ -45,7 +45,7 @@ public async Task<IActionResult> Index(string searchTerm)
       viewModel.Lyrics = await _lyricsService
         .SearchLyricsAsync(searchTerm);
 
-      return View(viewModel);
+      return View("Index", viewModel);
     }
   }
 }
diff --git a/Bejebeje.Mvc/Views/Artist/Index.cshtml b/Bejebeje.Mvc/Views/Artist/Index.cshtml
@@ -15,11 +15,7 @@
   </nav>
 </div>
 
-<div class="search">
-  <form asp-controller="Search" asp-action="Index" method="post" class="search__form">
-    <input class="search__input" placeholder="search for artist or lyric" name="searchTerm" />
-  </form>
-</div>
+@await Html.PartialAsync("_SearchForm")
 
 <div class="letters-wrapper">
   @foreach (char letter in dictionaryKeys)

diff --git a/Bejebeje.Mvc/Views/Home/Index.cshtml b/Bejebeje.Mvc/Views/Home/Index.cshtml
@@ -13,11 +13,7 @@
   </nav>
 </div>
 
-<div class="search">
-  <form asp-controller="Search" asp-action="Index" method="post" class="search__form">
-    <input class="search__input" placeholder="search for artist or lyric" name="searchTerm" />
-  </form>
-</div>
+@await Html.PartialAsync("_SearchForm")
 
 <section class="featured_list">
   <h2 class="featured_list__title">Recent Submissions</h2>

diff --git a/Bejebeje.Mvc/Views/Lyric/ArtistLyrics.cshtml b/Bejebeje.Mvc/Views/Lyric/ArtistLyrics.cshtml
@@ -11,11 +11,7 @@
   </nav>
 </div>
 
-<div class="search">
-  <form asp-controller="Search" asp-action="Index" method="post" class="search__form">
-    <input class="search__input" placeholder="search for artist or lyric" name="searchTerm" />
-  </form>
-</div>
+@await Html.PartialAsync("_SearchForm")
 
 @if (!Model.Artist.IsApproved)
 {

diff --git a/Bejebeje.Mvc/Views/Lyric/Lyric.cshtml b/Bejebeje.Mvc/Views/Lyric/Lyric.cshtml
@@ -11,11 +11,7 @@
   </nav>
 </div>
 
-<div class="search">
-  <form asp-controller="Search" asp-action="Index" method="post" class="search__form">
-    <input class="search__input" placeholder="search for artist or lyric" name="searchTerm" />
-  </form>
-</div>
+@await Html.PartialAsync("_SearchForm")
 
 @if (!Model.IsApproved)
 {

diff --git a/Bejebeje.Mvc/Views/Profile/Index.cshtml b/Bejebeje.Mvc/Views/Profile/Index.cshtml
@@ -9,11 +9,7 @@
   </nav>
 </div>
 
-<div class="search">
-  <form asp-controller="Search" asp-action="Index" method="post" class="search__form">
-    <input class="search__input" placeholder="search for artist or lyric" name="searchTerm" />
-  </form>
-</div>
+@await Html.PartialAsync("_SearchForm")
 
 <div class="actions">
   <h2 class="actions__heading">Want to help?</h2>

diff --git a/Bejebeje.Mvc/Views/Search/Index.cshtml b/Bejebeje.Mvc/Views/Search/Index.cshtml
@@ -12,11 +12,7 @@
   </nav>
 </div>
 
-<div class="search">
-  <form asp-controller="Search" asp-action="Index" method="post" class="search__form">
-    <input asp-for="@Model.SearchTerm" class="search__input" placeholder="artist name or lyric title" />
-  </form>
-</div>
+@await Html.PartialAsync("_SearchForm")
 
 <div class="results">
   @if (!Model.Lyrics.Any() && !Model.Artists.Any() && !string.IsNullOrEmpty(Model.SearchTerm))

diff --git a/Bejebeje.Mvc/Views/Shared/_SearchForm.cshtml b/Bejebeje.Mvc/Views/Shared/_SearchForm.cshtml
@@ -0,0 +1,6 @@
+<div class="search">
+  <form asp-controller="Search" asp-action="Search" method="get" class="search__form">
+    <input class="search__input" placeholder="search for artist or lyric" name="searchTerm" />
+  </form>
+</div>
+