Skip to content

Commit

Permalink
Merge pull request #88 from JuliaTrustworthyAI/87-move-plot-methods-t…
Browse files Browse the repository at this point in the history
…o-taijaplottingjl

done
  • Loading branch information
pat-alt authored Sep 7, 2023
2 parents e758c2f + 7a750b1 commit 9e3035f
Show file tree
Hide file tree
Showing 7 changed files with 1 addition and 377 deletions.
2 changes: 1 addition & 1 deletion Project.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "ConformalPrediction"
uuid = "98bfc277-1877-43dc-819b-a3e38c30242f"
authors = ["Patrick Altmeyer"]
version = "0.1.9"
version = "0.1.10"

[deps]
CategoricalArrays = "324d7699-5711-5eae-9e2f-1d82baa6b597"
Expand Down
1 change: 0 additions & 1 deletion src/conformal_models/conformal_models.jl
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ const ConformalModel = Union{

include("utils.jl")
include("heuristics.jl")
include("plotting.jl")

# Main API call to wrap model:
"""
Expand Down
322 changes: 0 additions & 322 deletions src/conformal_models/plotting.jl

This file was deleted.

30 changes: 0 additions & 30 deletions test/classification.jl
Original file line number Diff line number Diff line change
Expand Up @@ -51,36 +51,6 @@ conformal_models = merge(values(available_models[:classification])...)
@test !isnothing(conf_model.scores)
predict(mach, selectrows(X, test))

# Plotting:
@test isplot(bar(mach.model, mach.fitresult, X))
@test isplot(areaplot(mach.model, mach.fitresult, X, y))
@test isplot(
areaplot(mach.model, mach.fitresult, X, y; input_var=1)
)
@test isplot(
areaplot(mach.model, mach.fitresult, X, y; input_var=:x1)
)
if data_set[:specs][1] != 2
@test_throws AssertionError contourf(
mach.model, mach.fitresult, X, y
)
else
@test isplot(contourf(mach.model, mach.fitresult, X, y))
@test isplot(
contourf(
mach.model,
mach.fitresult,
X,
y;
zoom=-1,
plot_set_size=true,
),
)
@test isplot(
contourf(mach.model, mach.fitresult, X, y; target=1)
)
end

# Evaluation:
# Evaluation takes some time, so only testing for one method.
if _method == :simple_inductive && data_set[:specs][1] > 1
Expand Down
Loading

2 comments on commit 9e3035f

@pat-alt
Copy link
Member Author

@pat-alt pat-alt commented on 9e3035f Sep 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/90972

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.1.10 -m "<description of version>" 9e3035f8a9bf74320683d6d530f969ba3f82f2d3
git push origin v0.1.10

Please sign in to comment.