Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow skipping derivative computations #180

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

aplavin
Copy link

@aplavin aplavin commented May 29, 2024

I have some usecases where derivative is almost never useful for range enclosure, but takes the majority of calculations.

This PR makes it possible to pass df = nothing and skip all derivative-related computations.

Copy link
Member

@schillic schillic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this makes sense. May I ask you to add two changes?

  1. Add a test for df=nothing.
  2. Update the docstring of BranchAndBoundEnclosure (in algorithms.jl) to explain that df=nothing is a valid input that skips the check.

@aplavin
Copy link
Author

aplavin commented May 29, 2024

done

Copy link
Member

@schillic schillic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test failed. Please check again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants