-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor code into separate modules #84
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #84 +/- ##
=======================================
Coverage 96.54% 96.55%
=======================================
Files 20 23 +3
Lines 2373 2377 +4
=======================================
+ Hits 2291 2295 +4
Misses 82 82
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
I really feel like the SIMD polynomials should probably be a separate package since
|
Sounds good to me! I've moved the SIMD code over to https://github.com/heltonmc/SIMDMath.jl and will register later and come back to this in a couple days. Are we still ok with keeping the module structure here just minus the SIMDMath code? |
Registration at JuliaRegistries/General#79804. I'll come back Monday and update the airy functions with that dependency. I'm starting to wonder now if we just want to separate out all the functions into different modules (AiryFunctions, GammaFunctions, BesselFunctions, ..etc) and then just reexport them here. I know that was briefly discussed in SpecialFunctions.jl but I would definitely like to have some top line package that contains just julia code that brings together all of the special function libraries. Not for sure if all these different packages would be under JuliaMath or a different org (I don't want to spam too much the CI there). Right now this reorg exports |
Closed in favor of #95 |
As the project grows it might be best to separate namespaces into different modules. The motivation is that the constant polynomials take up a lot of namespace and it might be best to have unique functions into different modules.
In the future if someone wanted to split the package into smaller sub-packages this will help make that transition easier as well as be helpful as I add other functions (Scorer, Struve).
As of now I'm most interested how this affects package load / compile times so I will need to test that and clean some things up.
I think the pathway right now is:
Sounds like a lot but mostly there......