Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests for the recursive JSON formatter #11

Merged
merged 1 commit into from
Aug 20, 2023

Conversation

JamesWrigley
Copy link
Contributor

@JamesWrigley JamesWrigley commented Aug 20, 2023

JSON3 seems to be more powerful now and it properly serializes the NoStructTypeDefined struct. Replaced with a NaN to force an exception.

Should fix #10.

JSON3 seems to be more powerful now and it properly serializes the
`NoStructTypeDefined` struct. Replaced with a NaN to force an exception.
@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: +0.09% 🎉

Comparison is base (2b55273) 93.24% compared to head (68d6d8f) 93.33%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #11      +/-   ##
==========================================
+ Coverage   93.24%   93.33%   +0.09%     
==========================================
  Files           1        1              
  Lines          74       75       +1     
==========================================
+ Hits           69       70       +1     
  Misses          5        5              

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fredrikekre fredrikekre merged commit 5745d60 into JuliaLogging:master Aug 20, 2023
5 checks passed
@JamesWrigley JamesWrigley deleted the test-fixes branch August 20, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests fail
3 participants