-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Jupyter extension #498
Open
halleysfifthinc
wants to merge
15
commits into
JuliaGizmos:master
Choose a base branch
from
halleysfifthinc:webio_jupyter-updates
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+537
−907
Open
Changes from 13 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
ed377cf
Modernize AssetServer for new/current Jupyter Lab/Server extensions
halleysfifthinc cdc664b
Initial Jupyter extension updates
halleysfifthinc 6c761da
Adapt metadata field access deprecation to accessor function
halleysfifthinc a09843d
Update typescript config
halleysfifthinc 615f585
Update ignores
halleysfifthinc 9c85a16
Simplify build, build:prod, and clean:all scripts
halleysfifthinc 689422d
Use corepack instead of vendored yarn-berry
halleysfifthinc ef21134
Update jupyter extension CI
halleysfifthinc 6e1ce92
Remove observables callbacks when kernel changes (fixes #)
halleysfifthinc 00d0420
Force comm reconnect when comm is closed (e.g. kernel restarts, etc)
halleysfifthinc 0556c09
Fix non-working comms when viewing a notebook with old WebIO content
halleysfifthinc ceeba19
Bump jupyter extension version
halleysfifthinc 91571b8
Add debug logging tip to extension README
halleysfifthinc 4d2cc74
Update build and troubleshooting tips
halleysfifthinc e0fddba
Add release instructions and workflows created by jupyter-releaser
halleysfifthinc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,98 @@ | ||
name: Build Jupyter extension | ||
|
||
on: | ||
push: | ||
branches: main | ||
pull_request: | ||
branches: '*' | ||
|
||
jobs: | ||
build: | ||
runs-on: ubuntu-latest | ||
defaults: | ||
run: | ||
working-directory: webio_jupyter_extension | ||
|
||
steps: | ||
- name: Checkout | ||
uses: actions/checkout@v4 | ||
|
||
- name: Base Setup | ||
uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1 | ||
|
||
- name: Build WebIO (@webio/webio) | ||
working-directory: . | ||
run: | | ||
set -eux | ||
npm -C packages install --scripts-prepend-node-path=auto | ||
npm -C packages run build-prod --scripts-prepend-node-path=auto | ||
|
||
- name: Install dependencies | ||
run: | | ||
set -eux | ||
python -m pip install -U "jupyterlab>=4.0.0,<5" | ||
jlpm install | ||
|
||
- name: Lint the extension | ||
run: | | ||
set -eux | ||
jlpm | ||
jlpm run eslint:check | ||
|
||
- name: Build the extension | ||
run: | | ||
set -eux | ||
python -m pip install .[test] | ||
|
||
jupyter server extension list | ||
jupyter server extension list 2>&1 | grep -ie "webio_jupyter_extension.*OK" | ||
|
||
jupyter labextension list | ||
jupyter labextension list 2>&1 | grep -ie "webio-jupyterlab-provider.*OK" | ||
python -m jupyterlab.browser_check | ||
|
||
- name: Package the extension | ||
run: | | ||
set -eux | ||
|
||
pip install build | ||
python -m build | ||
pip uninstall -y "webio-jupyter-extension" jupyterlab | ||
|
||
- name: Upload extension packages | ||
uses: actions/upload-artifact@v4 | ||
with: | ||
name: extension-artifacts | ||
path: webio_jupyter_extension/dist/webio_jupyter_extension* | ||
if-no-files-found: error | ||
|
||
test_isolated: | ||
needs: build | ||
runs-on: ubuntu-latest | ||
|
||
steps: | ||
- name: Install Python | ||
uses: actions/setup-python@v5 | ||
with: | ||
python-version: '3.9' | ||
architecture: 'x64' | ||
- uses: actions/download-artifact@v4 | ||
with: | ||
name: extension-artifacts | ||
- name: Install and Test | ||
run: | | ||
set -eux | ||
# Remove NodeJS, twice to take care of system and locally installed node versions. | ||
sudo rm -rf $(which node) | ||
sudo rm -rf $(which node) | ||
|
||
pip install "jupyterlab>=4.0.0,<5" webio_jupyter_extension*.whl | ||
|
||
|
||
jupyter server extension list | ||
jupyter server extension list 2>&1 | grep -ie "webio_jupyter_extension.*OK" | ||
|
||
jupyter labextension list | ||
jupyter labextension list 2>&1 | grep -ie "webio-jupyterlab-provider.*OK" | ||
python -m jupyterlab.browser_check --no-browser-test | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,7 +12,7 @@ dist | |
yarn.lock | ||
node_modules | ||
*.js.map | ||
lerna-debug.log | ||
*.log | ||
package-lock.json | ||
*.tgz | ||
.yarn | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
enableImmutableInstalls: false |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,5 +3,6 @@ | |
"workspaces": [ | ||
"./webio_jupyter_extension", | ||
"./packages/*" | ||
] | ||
], | ||
"packageManager": "yarn@4.5.3" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1 @@ | ||
yarnPath: ".yarn/releases/yarn-berry.cjs" | ||
nodeLinker: node-modules |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't actually work with Requires (not sure why), but it does work in my weakdeps branch at #516 .