-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid introducing MPC.plot #120
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #120 +/- ##
=======================================
Coverage 98.93% 98.93%
=======================================
Files 24 24
Lines 3575 3575
=======================================
Hits 3537 3537
Misses 38 38 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
|
@baggepinnen |
I'm not entirely sure, but I think that documenting
Using RecipesBase is usually the most robust option in my experience, especially if you want the plot recipe to behave like an ordinary |
Alright I need to change the md file to make the online doc compiles. I'll do that when I'm back from Japan. You can also try if you have time but these kind of stuff can wait IMO |
…ot` to avoid confusion
see https://discourse.julialang.org/t/documenting-a-plot-recipe/122423/3 that's the best compromise I found to avoid the confusion. |
This PR tries to solve #119
RecipesBase.plot
is the function that is actually called when plotting a result object,ModelPredictiveControl.plot
is a different function with the same name (in another namespace), causing some confusion