(WIP) Add fix for iOS layout shadow wrapper #22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For layouts which use the position of the child element in the layout structure as the element's position (StackLayout, for example), the plugin works fine. However, for layouts where child node position may not have any correlation to the element's rendered UI (GridLayout, AbsoluteLayout, etc.), you end up running into problems.
For example, take the following layout on iOS:
Under the hood, this happens:
So the second label does not render correctly.
Currently this PR just applies the row, column, rowSpan, and colSpan attributes to the wrapping StackLayout if the original element is wrapped in a GridLayout.
More work needs to be done so that the wrapping StackLayout gets the correct attributes from the original element in order to render in the view correctly for all layouts - I believe #17 was caused by a similar issue for AbsoluteLayouts.
As-is, this is mergeable but does not account for all possible use cases.