Merge pull request #2 from JosephAwuku33/deploy

deployment branch
JosephAwuku33 · Oct 26, 2023 · 958f498 · 958f498
2 parents 0b9015e + a232ae1
commit 958f498
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 1 deletion.
diff --git a/.github/workflows/firebase-hosting-merge.yml b/.github/workflows/firebase-hosting-merge.yml
@@ -6,6 +6,15 @@ name: Deploy to Firebase Hosting on merge
   push:
     branches:
       - master
+
+env: # <--- here
+    REACT_APP_API_KEY: ${{secrets.REACT_APP_API_KEY}} # <--- here
+    REACT_APP_AUTH_DOMAIN: ${{secrets.REACT_APP_AUTH_DOMAIN}}
+    REACT_APP_PROJECT_ID: ${{secrets.REACT_APP_PROJECT_ID}}
+    REACT_APP_STORAGE_BUCKET: ${{secrets.REACT_APP_STORAGE_BUCKET}}
+    REACT_APP_MESSAGING_SENDING_ID: ${{secrets.REACT_APP_MESSAGING_SENDING_ID}}
+    REACT_APP_APP_ID: ${{secrets.REACT_APP_APP_ID}}
+
 jobs:
   build_and_deploy:
     runs-on: ubuntu-latest

diff --git a/.github/workflows/firebase-hosting-pull-request.yml b/.github/workflows/firebase-hosting-pull-request.yml
@@ -3,6 +3,15 @@
 
 name: Deploy to Firebase Hosting on PR
 'on': pull_request
+
+env: # <--- here
+    REACT_APP_API_KEY: ${{secrets.REACT_APP_API_KEY}} # <--- here
+    REACT_APP_AUTH_DOMAIN: ${{secrets.REACT_APP_AUTH_DOMAIN}}
+    REACT_APP_PROJECT_ID: ${{secrets.REACT_APP_PROJECT_ID}}
+    REACT_APP_STORAGE_BUCKET: ${{secrets.REACT_APP_STORAGE_BUCKET}}
+    REACT_APP_MESSAGING_SENDING_ID: ${{secrets.REACT_APP_MESSAGING_SENDING_ID}}
+    REACT_APP_APP_ID: ${{secrets.REACT_APP_APP_ID}}
+
 jobs:
   build_and_preview:
     if: '${{ github.event.pull_request.head.repo.full_name == github.repository }}'

diff --git a/src/components/ErrorAlert.js b/src/components/ErrorAlert.js
@@ -2,7 +2,7 @@ import React from 'react'
 
 export default function ErrorAlert({ message }) {
   return (
-    <div role="alert" className="mb-2">
+    <div role="alert" className="mb-3">
         <div className ="border border-red-dark rounded-b bg-light-red px-4 py-2 text-white">
             <p>{message}</p>
         </div>