Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates for CPP low level hits #848

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

sdobbs
Copy link
Contributor

@sdobbs sdobbs commented Oct 23, 2024

  • add handling of writing out all the appropriate fields for FMWPC hits to HDDM event format
  • add ability to apply thresholds to both the digit hit amplitude and integral. we can implement the appropriate CCDB table after this

@aaust
Copy link
Contributor

aaust commented Oct 24, 2024

I tried to write out events with randomtrigger_skim from a CPP evio file, and I get these entries:

      <fmwpcChamber layer="6" wire="77">
          <fmwpcHit dE="0" t="184">
            <fmwpcHitQ q="0" />
            <fmwpcHitQ q="1194" />
            <fmwpcDigiHit amp="0" ped="0" qf="0" />
          </fmwpcHit>
        </fmwpcChamber>
        <fmwpcChamber layer="6" wire="78">
          <fmwpcHit dE="0" t="340.8">
            <fmwpcHitQ q="0" />
            <fmwpcHitQ q="1663" />
            <fmwpcDigiHit amp="0" ped="0" qf="0" />
          </fmwpcHit>
        </fmwpcChamber>

For comparison, the master produces this:

        <fmwpcChamber layer="6" wire="77">
          <fmwpcHit dE="0" t="184">
          </fmwpcHit>
        </fmwpcChamber>
        <fmwpcChamber layer="6" wire="78">
          <fmwpcHit dE="0" t="340.8">
          </fmwpcHit>
        </fmwpcChamber>

Do you understand why HitQ is written out twice, once with 0 value? And why are all digihit entries 0?

@aaust
Copy link
Contributor

aaust commented Nov 6, 2024

@sdobbs Did you have any more insights on this?

@sdobbs
Copy link
Contributor Author

sdobbs commented Nov 6, 2024

Thanks for the reminder on this, I will take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants