feat: agency id validation notices #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checks are likely failing related to this issue: |
|
Moved PR to 1318 |
briandonahue
pushed a commit
that referenced
this pull request
Apr 12, 2023
…ityData#1382) * Upgrade to Gradle 7.4 so that we can use the new `testReportAggregation`, which is a more standard way of aggregating test reports across all sub-projects. Use this opportunity to consolidate a bunch of test options into the root project for consistent configuration. * Comment tweak. * Restore code to make sure `copyRulesMarkdown` runs before test execution. * Make sure affected sources are in consistent sorted order for repeatable test execution. * Disable UI tests in headless environments. * Fix failing test on Windows due to line separators. * Attempt #2 to test correctly under Windows. * Consolidate Java compile options for consistency across projects. This will also help some tests pass on Windows environments. * Get another test passing on Windows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Addresses MobilityData#878
agency_idif more than one agency inagency.txtagency.txtbutagency_idis not providedagency_idis missing inroutes.txtand a single agency is defined inagency.txtwith noagency_idagency_idis missing inroutes.txtbut is included for single agency inagency.txtExpected behavior:
N/A
Please make sure these boxes are checked before submitting your pull request - thanks!
gradle testto make sure you didn't break anything