Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terrain rotation tool fix #290

Merged
merged 1 commit into from
Jul 28, 2024
Merged

Terrain rotation tool fix #290

merged 1 commit into from
Jul 28, 2024

Conversation

Dgzt
Copy link
Collaborator

@Dgzt Dgzt commented Jul 10, 2024

This is the fix for #284 bug.

I don't know why was there the terrain checking in the scale tool, so I removed it. Now the scaling works perfectly with terrain too.

@Dgzt Dgzt linked an issue Jul 10, 2024 that may be closed by this pull request
Scale tool doesn't work for terrain #284
Closed
JamesTKhan
JamesTKhan approved these changes Jul 28, 2024
View reviewed changes
Copy link
Owner

@JamesTKhan JamesTKhan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alot of the old terrain class code did not support scaling but I believe most of that has been addressed over time.

@JamesTKhan JamesTKhan merged commit 15f4204 into JamesTKhan:master Jul 28, 2024
1 check passed
@Dgzt Dgzt deleted the terrain-rotation-tool-fix branch July 29, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesTKhan JamesTKhan JamesTKhan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scale tool doesn't work for terrain
2 participants
@Dgzt @JamesTKhan