Merge pull request #295 from fadam87/optimalization

Optimalization
JamesTKhan · Nov 22, 2024 · d4e8cea · d4e8cea
2 parents 3a7f97b + 50302b8
commit d4e8cea
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 2 deletions.
diff --git a/commons/src/main/com/mbrlabs/mundus/commons/scene3d/GameObject.java b/commons/src/main/com/mbrlabs/mundus/commons/scene3d/GameObject.java
@@ -266,7 +266,19 @@ public Array<GameObject> findChildrenByName(String name) {
      * @return Array of all matching GameObjects
      */
     public Array<GameObject> findChildrenByComponent(Component.Type type) {
-        Array<GameObject> objects = new Array<>();
+
+        return findChildrenByComponent(type, new Array<GameObject>());
+    }
+
+    /**
+     * Returns an Array of all child GameObjects that have the given Component.Type
+     *
+     * @param type the Component Type to search for
+     * @param objects an Array to collect matching GameObjects (uploading array)
+     * @return Array of all matching GameObjects
+     */
+    public Array<GameObject> findChildrenByComponent(Component.Type type, Array<GameObject> objects) {
+
         for (GameObject go : this) {
             Component component = go.findComponentByType(type);
             if (component != null) {
@@ -284,7 +296,19 @@ public Array<GameObject> findChildrenByComponent(Component.Type type) {
      * @return Array of all matching GameObjects
      */
     public Array<GameObject> findChildrenByTag(String tag) {
-        Array<GameObject> objects = new Array<>();
+
+        return findChildrenByTag(tag, new Array<GameObject>());
+    }
+
+    /**
+     * Returns an Array of all child GameObjects that have the given Tag
+     *
+     * @param tag the string tag to search for
+     * @param objects an Array to collect matching GameObjects (uploading array)
+     * @return Array of all matching GameObjects
+     */
+    public Array<GameObject> findChildrenByTag(String tag, Array<GameObject> objects) {
+
         for (GameObject go : this) {
             if (go.tags != null && go.tags.contains(tag, false)) {
                 objects.add(go);

diff --git a/gdx-runtime/CHANGES b/gdx-runtime/CHANGES
@@ -9,6 +9,7 @@
 - Generic findComponentsByType and findComponentByType methods
 - Fix render water if it is child game object
 - Update gdx-gltf version to 2.2.1
+- Add findChildrenByComponent(Component.Type, Array<GameObject>) and findChildrenByTag(String, Array<GameObject>) methods into GameObject file
 - Set source compatibility to 1.8
 
 [0.5.1] ~ 08/08/2023