Pressing "tab" when last textField of entry editor Tab is in focus will move to the next Tab. #12087

Noah-Martin1 · 2024-10-26T01:54:16Z

Pressing "tab" when the last TextField of the entry editor Tab is in focus will move to the next Tab.

Closes #11937

What I have done

Changed a method in EditorTextField, (EditorTextField()), that adds an EventFilter to the relative TextField, listening for "tab" presses. If "tab" is pressed it checks if the current TextField is the last one of its TabPane by calling EntryEditor.checkLastTextField. This method retrieves the last Field of the current TabPane and compares its name with the ID of the TextField. If true the TextField is the last one of its TabPane and the next TabPane will be selected.

The reason the ID of TextField should be equal to the name of its corresponding Field is because in classes, PersonsEditor, SimpleEditor and CitationKeyEditor the TextField created from the original Field has been set an ID of the Field's display name.

How this changes UI experience

After clicking a TextField and bringing it to focus, pressing "tab" will cycle through all the succeeding TextFields (the ones below it) until it reaches the last one and then it will switch TabPane to the next one toward the right. (see below)

Mandatory checks

I own the copyright of the code submitted and I licence it under the MIT license
Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
[/] Tests created for changes (if applicable)
Manually tested changed features in running JabRef (always required)
Screenshots added in PR description (for UI changes)
Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

…ed fields" because the "CitationKey" isnt created in SimpleEditor.java and therefore hasn't had its textfield id updated.

subhramit

Few requests on code quality.

subhramit · 2024-10-26T10:59:21Z

src/main/java/org/jabref/gui/entryeditor/EntryEditor.java

+        Field lastField = null;
+        for (Field field : shownFields) {
+            lastField = field;
+        }
+        if (textField != null && lastField != null) {
+            if (textField.getId() == null) {


Pease use Optionals in place of nulls.

subhramit · 2024-10-26T11:02:42Z

src/main/java/org/jabref/gui/entryeditor/EntryEditor.java

@@ -472,4 +475,20 @@ public void nextPreviewStyle() {
    public void previousPreviewStyle() {
        this.previewTabs.forEach(OffersPreview::previousPreviewStyle);
    }
+
+    public static boolean checkLastTextField(TabPane tabs, TextField textField) {


Please make this non-static.

Hey,
Sorry, I'm not sure how. I believe I can make checkLastTextField non-static and use the tabbed TabPane in the EntryEditor instead. But in doing this, I would need to create a new instance of EntryEditor in EditorTextField which will require the following arguments: EntryEditor(LibraryTab libraryTab, UndoAction undoAction, RedoAction redoAction). -> which I'm not sure how to get from EditorTextField.
Please guide me how I could do this.
Thankyou!

Why would you need a new instance of an entry editor? We only have one.
How about this?

If im calling the non-static method checkLastTextField that's in EntryEditor, that uses private TabPane tabbed from EditorTextField. It requires me to create a new instance of EntryEditor in EditorTextField. I believe

If you create a new instance of an EntryEditor your changes would not affect the one we are displaying. There is only one EntryEditor. You probably have to inject a reference to the object you need.
But I believe there is a more serious architectural flaw, if you are trying to get a reference to to the big container node.
Why would you need the entry editor? Why would you need the TabbedPane? And what exactly do you need from the TabbedPane?

You can 'inject' a method selectNextTab or sthg as a functional interface if really necessary.

I need the TabPane to get the last Field of a tab and to select the next Tab

subhramit · 2024-10-26T11:04:55Z

src/main/java/org/jabref/gui/fieldeditors/EditorTextField.java

 import org.jabref.gui.fieldeditors.contextmenu.EditorContextAction;
 import org.jabref.gui.keyboard.KeyBindingRepository;

 public class EditorTextField extends TextField implements Initializable, ContextMenuAddable {

+    public static TabPane tabs;


Please make it non-static.

subhramit · 2024-10-26T11:05:22Z

src/main/java/org/jabref/gui/fieldeditors/EditorTextField.java

@@ -38,6 +49,10 @@ public EditorTextField(final String text) {
        ClipBoardManager.addX11Support(this);
    }

+    public static void entryContext(TabPane tab) {


Non-static.

koppor · 2024-10-26T23:50:34Z

For reviewers - technical discussions were done at #11937 (comment), too.

subhramit · 2024-11-25T06:56:33Z

@Noah-Martin1 hey, sorry that the PR got a little stale. Were you able to figure out a way to conform to the remaining review comments? Did you try injecting the methods you needed using functional interfaces as suggested by @calixtus ?

Noah-Martin1 · 2024-11-25T07:14:54Z

@Noah-Martin1 hey, sorry that the PR got a little stale. Were you able to figure out a way to conform to the remaining review comments? Did you try injecting the methods you needed using functional interfaces as suggested by @calixtus ?

Hi sorry I have been on break since, and haven’t had a chance to look at it. I will look into the suggestions in a couple weeks. Thankyou

Noah Martin added 10 commits October 25, 2024 22:33

Pressing tab cycles through most of the tabs. need to look at "Requir…

0047c50

…ed fields" because the "CitationKey" isnt created in SimpleEditor.java and therefore hasn't had its textfield id updated.

Pressing tab cycles through most of the tabs. need to look at "Requir…

c94c433

…ed fields" because the "CitationKey" isnt created in SimpleEditor.java and therefore hasn't had its textfield id updated.

fixing style

e98bd27

fixing style

c80ed8c

fixing style

334c467

fixing style

04b0f0b

fixing style

0afd9ce

fixing style

1ee9a0e

fixing style

2a167bd

added to CHANGELOG.md

2842f72

Noah-Martin1 mentioned this pull request Oct 26, 2024

Tab in the last text field in a tab should focus the next tab in the tabs of the entry editor. #11937

Open

subhramit requested changes Oct 26, 2024

View reviewed changes

koppor added the status: changes required Pull requests that are not yet complete label Oct 31, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pressing "tab" when last textField of entry editor Tab is in focus will move to the next Tab. #12087

Pressing "tab" when last textField of entry editor Tab is in focus will move to the next Tab. #12087

Noah-Martin1 commented Oct 26, 2024 •

edited by subhramit

Loading

subhramit left a comment

subhramit Oct 26, 2024

subhramit Oct 26, 2024

Noah-Martin1 Oct 26, 2024

calixtus Oct 26, 2024

Noah-Martin1 Oct 26, 2024 •

edited

Loading

calixtus Oct 26, 2024

calixtus Oct 26, 2024 •

edited

Loading

Noah-Martin1 Oct 26, 2024

subhramit Oct 26, 2024

subhramit Oct 26, 2024

koppor commented Oct 26, 2024

subhramit commented Nov 25, 2024 •

edited

Loading

Noah-Martin1 commented Nov 25, 2024

Pressing "tab" when last textField of entry editor Tab is in focus will move to the next Tab. #12087

Are you sure you want to change the base?

Pressing "tab" when last textField of entry editor Tab is in focus will move to the next Tab. #12087

Conversation

Noah-Martin1 commented Oct 26, 2024 • edited by subhramit Loading

Pressing "tab" when the last TextField of the entry editor Tab is in focus will move to the next Tab.

What I have done

How this changes UI experience

Mandatory checks

subhramit left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Noah-Martin1 Oct 26, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

calixtus Oct 26, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

koppor commented Oct 26, 2024

subhramit commented Nov 25, 2024 • edited Loading

Noah-Martin1 commented Nov 25, 2024

Noah-Martin1 commented Oct 26, 2024 •

edited by subhramit

Loading

Noah-Martin1 Oct 26, 2024 •

edited

Loading

calixtus Oct 26, 2024 •

edited

Loading

subhramit commented Nov 25, 2024 •

edited

Loading