Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add uses directive #11761

Merged
merged 2 commits into from
Sep 15, 2024
Merged

Add uses directive #11761

merged 2 commits into from
Sep 15, 2024

Conversation

koppor
Copy link
Member

@koppor koppor commented Sep 15, 2024

Reported by @Siedlerchr

e java.lang.Exception: java.util.ServiceConfigurationError: ai.djl.repository.zoo.ZooProvider: module org.jabref.merged.module does not declare `uses`
	at org.jabref@5.16.30482/org.jabref.gui.util.uitaskexecutor.converttoexception(uitaskexecutor.java:215)
...
Caused by: java.util.ServiceConfigurationError: ai.djl.repository.zoo.ZooProvider: module org.jabref.merged.module does not declare `uses`
	at java.base/java.util.ServiceLoader.fail(ServiceLoader.java:593)

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@Siedlerchr
Copy link
Member

This is for merged module, neecs to be adjusted in the gradle file

@koppor
Copy link
Member Author

koppor commented Sep 15, 2024

This is for merged module, neecs to be adjusted in the gradle file

In addition I guess...

Copy link
Contributor

github-actions bot commented Sep 15, 2024

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@Siedlerchr Siedlerchr added this pull request to the merge queue Sep 15, 2024
Merged via the queue into main with commit 86874f4 Sep 15, 2024
31 checks passed
@Siedlerchr Siedlerchr deleted the fix-ai-uses branch September 15, 2024 13:03
@koppor
Copy link
Member Author

koppor commented Sep 15, 2024

@InAnYan Check the diff. Interesting learning about Java modules...

@Siedlerchr
Copy link
Member

The issues arose because the djl library is not modularized properly, so it needs to be put in the merged module ("merged module") and as it uses service loaders, we need to specify the implementations as well

@koppor
Copy link
Member Author

koppor commented Sep 15, 2024

The issues arose because the djl library is not modularized properly, so it needs to be put in the merged module ("merged module") and as it uses service loaders, we need to specify the implementations as well

Is there already an issue at that repo @InAnYan ?

@Siedlerchr
Copy link
Member

deepjavalibrary/djl#3473

@InAnYan
Copy link
Collaborator

InAnYan commented Sep 15, 2024

Oh, I see.

Great that you worked it out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants