-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial CI pipeline #17
Open
brennerd11
wants to merge
38
commits into
JEMRIS:master
Choose a base branch
from
brennerd11:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d46b697.
…w installaion of CLN/Ginac fails
WARNING: Users increase tolerance of 0.2% for CI tests to allow passing test for radial xml.
Allows to run jemris as docker container by e.g. using docker run -v $PWD:/home/jemris/sim myjemris 1chext.xml (assumption invoked from examples directory) when the docker container was initially built using docker build . -t myjemris from the root of the jemris directory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear @stoeckert,
this PR adds
Benefits:
CI pipeline will provide feedback on each commit if it is buildable. It can also be used as a check within a branch protection of the main branch which will block anything not fulfilling the checks to be merged to main.
Tests (ctest) are also invoked after compilation
Current issues and limitations:
Currently multiple tests (coils, signals, mpi) fail - I would assume some runtime libraries may be missing. I will have a look into as soon as I find some time but hopefully it can be a starting point for this anyways.
Compilation is currently only done on a single linux instance. Windows and MacOs are currently not considered (possible via matrix builds)
Happy to discuss!
Cheers,
Daniel