Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial CI pipeline #17

Open
wants to merge 38 commits into
base: master
Choose a base branch
from
Open

Initial CI pipeline #17

wants to merge 38 commits into from

Conversation

brennerd11
Copy link
Contributor

Dear @stoeckert,

this PR adds

  • devcontainer setup for local development in VS code (within a specific container setup carrying necessary dependencies)
  • a Github action pipeline that is triggered on PRs and automatically performs compilation and testing

Benefits:
CI pipeline will provide feedback on each commit if it is buildable. It can also be used as a check within a branch protection of the main branch which will block anything not fulfilling the checks to be merged to main.
Tests (ctest) are also invoked after compilation

Current issues and limitations:
Currently multiple tests (coils, signals, mpi) fail - I would assume some runtime libraries may be missing. I will have a look into as soon as I find some time but hopefully it can be a starting point for this anyways.
Compilation is currently only done on a single linux instance. Windows and MacOs are currently not considered (possible via matrix builds)

Happy to discuss!

Cheers,

Daniel

 WARNING: Users increase tolerance of 0.2% for CI tests to allow passing test for radial xml.
Allows to run jemris as docker container by e.g. using

docker run -v $PWD:/home/jemris/sim myjemris 1chext.xml

(assumption invoked from examples directory)

when the docker container was initially built using

docker build . -t myjemris

from the root of the jemris directory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant