-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update htlm related refs for OOPS PR "Hybrid TLM clean up" #1070
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small differences. Some are "worse" but I don't think that's really true given this is just a basic software test. Thanks!
@kbhargava you need to put build-group=https://github.com/JCSDA-internal/oops/pull/2734 in the description so that the CI builds with the right branches |
Thanks Travis. I did not know this. Added it in the description. Hopefully ctests pass now. :) |
Thanks!! Also given we have the issue of RMSE and unrealistic initial perturbations, I am not worried too much about these tests. We are working on more realistic case with larger ensemble size. That would be a better test of "science". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1e10
... still a long way from 1e308
, so 👍
Looks like the test reference needs merging with develop. |
Thanks for pinting thi @shlyaeva let me fix it. |
Description
Update testrefs for https://github.com/JCSDA-internal/oops/pull/2734
Issue(s) addressed
Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)
Testing
Tested on orion with gnu that ctest pass
Dependencies
build-group=https://github.com/JCSDA-internal/oops/pull/2734