Handle missing station data file rather than exiting with an exception #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EdwardSafford-NOAA
requested review from
CoryMartin-NOAA,
ADCollard and
kevindougherty-noaa
|
I don't have the authority to merge PRs if the tests fail, so we will need to get the CI passing before we can merge |
|
@CoryMartin-NOAA CI tests are good to go now, so this can be merged. |
CoryMartin-NOAA
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add zeroed data if a station data file is missing to ensure continued execution.
Resolves #197
Dependencies
Not a huge deal but I started this branch from my fix for #196 so that should be merged before this change.