Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up mon_data_space.py #176

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Clean up mon_data_space.py #176

merged 1 commit into from
Jan 24, 2024

Conversation

EdwardSafford-NOAA
Copy link
Contributor

Some light cleanup to mon_data_space.py:

  • Remove nvars variable
  • add check to drop_coordinate method to avoid warning message

There was more interface work when I opened this issue but much of it was done in earlier PRs.

Closes #165

@EdwardSafford-NOAA
Ref JCSDA-internal#165
d6f4517 
Light cleanup & remove nvars variable.
@CoryMartin-NOAA CoryMartin-NOAA merged commit 7ef27ee into JCSDA-internal:develop Jan 24, 2024
5 checks passed
@EdwardSafford-NOAA EdwardSafford-NOAA deleted the feature/interface-165 branch March 11, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CoryMartin-NOAA CoryMartin-NOAA CoryMartin-NOAA approved these changes

@ADCollard ADCollard Awaiting requested review from ADCollard

@kevindougherty-noaa kevindougherty-noaa Awaiting requested review from kevindougherty-noaa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clean up interfaces in data/mon_data_space.py
2 participants
@EdwardSafford-NOAA @CoryMartin-NOAA