-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for DA monitor binary station data files #160
Merged
CoryMartin-NOAA
merged 7 commits into
JCSDA-internal:develop
from
EdwardSafford-NOAA:feature/stn-84
Oct 18, 2023
Merged
Add support for DA monitor binary station data files #160
CoryMartin-NOAA
merged 7 commits into
JCSDA-internal:develop
from
EdwardSafford-NOAA:feature/stn-84
Oct 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
save work in progress
Save work in progress.
Save work in progress
Save work in progress
Merge branch 'develop' into feature/stn-84
Clean up pycode issues
EdwardSafford-NOAA
requested review from
CoryMartin-NOAA,
ADCollard and
kevindougherty-noaa
October 16, 2023 18:29
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple brief questions/comments but otherwise looks good from what I can tell
Align station data datasets, filing in NaN for all missing values. Merge as per non-station datasets and we're golden.
EdwardSafford-NOAA
changed the title
Feature/stn 84
Add support for DA monitor binary station data files
Oct 17, 2023
CoryMartin-NOAA
approved these changes
Oct 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extend
data/mon_data_space.py
to support legacy DA monitor binary station data files. These are a binary files with a header on each observation record. The header includes the station data (station id, lat, lon, etc). The accompanying control file only indicates the variable information but does not include the number of observations. This can only be learned by reading the data file.This completes issue #84 .
Dependencies
None
Impact
None