Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for DA monitor binary station data files #160

Merged

Conversation

EdwardSafford-NOAA
Copy link
Contributor

Description

Extend data/mon_data_space.py to support legacy DA monitor binary station data files. These are a binary files with a header on each observation record. The header includes the station data (station id, lat, lon, etc). The accompanying control file only indicates the variable information but does not include the number of observations. This can only be learned by reading the data file.

This completes issue #84 .

Dependencies

None

Impact

None

save work in progress
Save work in progress.
Save work in progress
Save work in progress
Merge branch 'develop' into feature/stn-84
Clean up pycode issues
Copy link
Collaborator

@CoryMartin-NOAA CoryMartin-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple brief questions/comments but otherwise looks good from what I can tell

src/eva/data/mon_data_space.py Outdated Show resolved Hide resolved
src/eva/data/mon_data_space.py Outdated Show resolved Hide resolved
@EdwardSafford-NOAA EdwardSafford-NOAA marked this pull request as draft October 16, 2023 19:06
Align station data datasets, filing in NaN for all missing values.
Merge as per non-station datasets and we're golden.
@EdwardSafford-NOAA EdwardSafford-NOAA changed the title Feature/stn 84 Add support for DA monitor binary station data files Oct 17, 2023
@EdwardSafford-NOAA EdwardSafford-NOAA marked this pull request as ready for review October 17, 2023 18:47
Copy link
Collaborator

@CoryMartin-NOAA CoryMartin-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@CoryMartin-NOAA CoryMartin-NOAA merged commit ae02f4d into JCSDA-internal:develop Oct 18, 2023
5 checks passed
@EdwardSafford-NOAA EdwardSafford-NOAA deleted the feature/stn-84 branch January 4, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants