Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.html #116

Merged
merged 1 commit into from
Jan 14, 2024
Merged

Update index.html #116

merged 1 commit into from
Jan 14, 2024

Conversation

tushargupta1504
Copy link
Contributor

@tushargupta1504 tushargupta1504 commented Jan 13, 2024

The script tag for tailwind.config is not included correctly. It should be wrapped in a script tag with a type attribute.

You are using the tailwind.config script but have not included Tailwind CSS in your project. If you are not using Tailwind CSS, you can remove this script.

You have included jQuery and ScrollReveal scripts, but it seems you haven't used them in your code. If you don't need them, you can remove these scripts.

There is an issue with the font-awesome script inclusion. It should use the https protocol. Update the link as follows:

The <script src="https://cdn.tailwindcss.com"></script> script is unnecessary and can be removed if you're not using Tailwind CSS.

The <script async src="https://www.googletagmanager.com/gtag/js?id=G-80WSMNJP27"></script> and the related Google Analytics script are included, but they won't work unless you have a valid Google Analytics property ID. If you don't use Google Analytics, you can remove these scripts.

The href attribute for the tags in the social media section is set to placeholder values. Make sure to replace them with your actual social media links.

The Twitter logo has a style attribute with an incorrect width property. Change width: full; to width: 100%;.

The scroll-reveal.js script is included, but the script file is not referenced correctly. Make sure to provide the correct path or remove it if not needed.

..

Related Issue

Closes #issue_number

Description

Screenshots (if applicable)

Original Updated
original screenshot updated screenshot

Checklist

  • My code adheres to the established style guidelines of the project.
  • I have included comments in areas that may be difficult to understand.
  • My changes have not introduced any new warnings.
  • I have conducted a self-review of my code.

The script tag for tailwind.config is not included correctly. It should be wrapped in a script tag with a type attribute.

You are using the tailwind.config script but have not included Tailwind CSS in your project. If you are not using Tailwind CSS, you can remove this script.

You have included jQuery and ScrollReveal scripts, but it seems you haven't used them in your code. If you don't need them, you can remove these scripts.

There is an issue with the font-awesome script inclusion. It should use the https protocol. Update the link as follows:


The <script src="https://cdn.tailwindcss.com"></script> script is unnecessary and can be removed if you're not using Tailwind CSS.

The <script async src="https://www.googletagmanager.com/gtag/js?id=G-80WSMNJP27"></script> and the related Google Analytics script are included, but they won't work unless you have a valid Google Analytics property ID. If you don't use Google Analytics, you can remove these scripts.

The href attribute for the <a> tags in the social media section is set to placeholder values. Make sure to replace them with your actual social media links.

The Twitter logo has a style attribute with an incorrect width property. Change width: full; to width: 100%;.

The scroll-reveal.js script is included, but the script file is not referenced correctly. Make sure to provide the correct path or remove it if not needed.

..
Copy link

vercel bot commented Jan 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
virtuo-learn ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 13, 2024 6:39pm

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @tushargupta1504! 🎉 Thank you for submitting your pull request for Virtuo-Learn. Our dedicated team will review it diligently.Your contribution is valuable and we appreciate your efforts to improve our project.

@tushargupta1504
Copy link
Contributor Author

The script tag for tailwind.config is not included correctly. It should be wrapped in a script tag with a type attribute.

You are using the tailwind.config script but have not included Tailwind CSS in your project. If you are not using Tailwind CSS, you can remove this script.

You have included jQuery and ScrollReveal scripts, but it seems you haven't used them in your code. If you don't need them, you can remove these scripts.

There is an issue with the font-awesome script inclusion. It should use the https protocol. Update the link as follows:

The <script src="https://cdn.tailwindcss.com"></script> script is unnecessary and can be removed if you're not using Tailwind CSS.

The <script async src="https://www.googletagmanager.com/gtag/js?id=G-80WSMNJP27"></script> and the related Google Analytics script are included, but they won't work unless you have a valid Google Analytics property ID. If you don't use Google Analytics, you can remove these scripts.

The href attribute for the tags in the social media section is set to placeholder values. Make sure to replace them with your actual social media links.

The Twitter logo has a style attribute with an incorrect width property. Change width: full; to width: 100%;.

The scroll-reveal.js script is included, but the script file is not referenced correctly. Make sure to provide the correct path or remove it if not needed.

@JAYESHBATRA JAYESHBATRA merged commit 1e9327d into JAYESHBATRA:main Jan 14, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants