Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make package instead of plugin #7

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

danlapteacru
Copy link
Contributor

No description provided.

@private-packagist
Copy link

composer.lock

Dev Package changes

Package Operation From To Changes
dealerdirect/phpcodesniffer-composer-installer add - v0.7.2 view code
itinerisltd/itineris-wp-coding-standards add - 0.4.0 view code
squizlabs/php_codesniffer add - 3.7.1 view code
wp-coding-standards/wpcs add - 2.3.0 view code
roave/security-advisories remove dev-master 4ed057f - -

Settings · Docs · Powered by Private Packagist

"require": {
"php": "^7.4|^8.0"
"php": "^7.3|^8.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"php": "^7.3|^8.0"
"php": "^7.4|^8.0"

@@ -0,0 +1,51 @@
<?xml version="1.0"?>
<ruleset name="Sage">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not sage boo

@@ -0,0 +1,18 @@
<?php
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strict types in file?

@@ -121,7 +121,8 @@ public function deletedPost(int $post_id): void
flush_rewrite_rules();
}

public function bodyClass($classes): array {
public function bodyClass($classes): array
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public function bodyClass($classes): array
public function bodyClass(array $classes): array

@@ -107,7 +107,8 @@ public function deletedPost(int $post_id): void
flush_rewrite_rules();
}

public function bodyClass($classes): array {
public function bodyClass($classes): array
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public function bodyClass($classes): array
public function bodyClass(array $classes): array

@danlapteacru danlapteacru marked this pull request as draft November 15, 2022 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants