Us10.1 filter panel new design #159

hry625 · 2023-01-16T11:57:59Z

Description:

Implementing the new design of filter panel
Allow user to create multiple filter sets.

Useful notes:

Knowing issues:

Add new filter set button will not update the filter sets input div automatically.
Strange layout position of "Field" and "value" Label when the filter sets is empty.
The overfollow of the panels stack position will be fixed in a later PR.
Filter sets history function is missing.(This will be fixed in the other PR.)
Could not input the key value with pre-defined keybinding. (This will be fixed in the other PR.)

Screenshots:

Preview of filter panel:

… to the new design. #10

…to the new design. #10

Bumps [loader-utils](https://github.com/webpack/loader-utils) from 2.0.2 to 2.0.3. - [Release notes](https://github.com/webpack/loader-utils/releases) - [Changelog](https://github.com/webpack/loader-utils/blob/v2.0.3/CHANGELOG.md) - [Commits](webpack/loader-utils@v2.0.2...v2.0.3) --- updated-dependencies: - dependency-name: loader-utils dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>

…tions (ItJustWorksTM#121)

generated by cargo update

…orksTM#140) Bumps [minimatch](https://github.com/isaacs/minimatch) from 3.0.4 to 3.1.2. - [Release notes](https://github.com/isaacs/minimatch/releases) - [Commits](isaacs/minimatch@v3.0.4...v3.1.2) --- updated-dependencies: - dependency-name: minimatch dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…stWorksTM#128) Bumps [loader-utils](https://github.com/webpack/loader-utils) from 2.0.3 to 2.0.4. - [Release notes](https://github.com/webpack/loader-utils/releases) - [Changelog](https://github.com/webpack/loader-utils/blob/v2.0.4/CHANGELOG.md) - [Commits](webpack/loader-utils@v2.0.3...v2.0.4) --- updated-dependencies: - dependency-name: loader-utils dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Co-authored-by: renyuan <hry87625@gmail.com> Co-authored-by: Kevin Ayad <kevinayad@Kevins-MacBook-Pro.local> Co-authored-by: Kevinayad <kevinayad@hotmail.com> Co-authored-by: Alexandre Rancati-Palmer <a.rancatipalmer@mailo.com> Co-authored-by: Kamila Y <75277107+kam56@users.noreply.github.com> Co-authored-by: Alexandre Rancati-Palmer <71485862+alrapal@users.noreply.github.com>

adds lower_case and partial options for now, this means the backend will alter the way the nodes are matched. note: client provided string is not modified.

frontend: refactor the overall layout Co-authored-by: Alexandre Rancati-Palmer <71485862+alrapal@users.noreply.github.com> Co-authored-by: Karl Nilsson <44969574+ktpa@users.noreply.github.com>

… and add_tempFIlter_to_query

…s array

…uery data structure

…query datastructure

…erWidget.

…M#145)

…JustWorksTM#146) frontend: Introduce settings window and shuffle code around

…filter panel branch.

…itles.

…pdate.

…ead.

…ilter set display when use select node as root.

Bumps [loader-utils](https://github.com/webpack/loader-utils) from 2.0.2 to 2.0.3. - [Release notes](https://github.com/webpack/loader-utils/releases) - [Changelog](https://github.com/webpack/loader-utils/blob/v2.0.3/CHANGELOG.md) - [Commits](webpack/loader-utils@v2.0.2...v2.0.3) --- updated-dependencies: - dependency-name: loader-utils dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>

…tions (ItJustWorksTM#121)

…stWorksTM#128) Bumps [loader-utils](https://github.com/webpack/loader-utils) from 2.0.3 to 2.0.4. - [Release notes](https://github.com/webpack/loader-utils/releases) - [Changelog](https://github.com/webpack/loader-utils/blob/v2.0.4/CHANGELOG.md) - [Commits](webpack/loader-utils@v2.0.3...v2.0.4) --- updated-dependencies: - dependency-name: loader-utils dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

adds lower_case and partial options for now, this means the backend will alter the way the nodes are matched. note: client provided string is not modified.

…JustWorksTM#146) frontend: Introduce settings window and shuffle code around

…WorksTM#148)

Co-authored-by: Alexandre Rancati-Palmer <a.rancatipalmer@mailo.com>

ktpa · 2023-01-17T15:22:26Z

The correct spelling here is "Delete".
Upon creating a filter, you are on submit taken to the filtered event node. However - exiting this (undo) takes you back in both zoom level and positioning to the original origo in the graph, possibly not intended.

Substringing doesn't seem to work properly.

Deselecting "Active" but keeping substring causes weird behaviour.
Selecting a node, submitting that filter then undoing, and submitting again makes nothing happen at the last step.

A couple of issues I discovered while testing.

hry625 · 2023-01-17T15:58:14Z

The correct spelling here is "Delete".

I will fix that.

Upon creating a filter, you are on submit taken to the filtered event node. However - exiting this (undo) takes you back in both zoom level and positioning to the original origo in the graph, possibly not intended.

I think this behavior is inherited from the original design, we need to discuss about expected behavior in this case

Substringing doesn't seem to work properly.

Substring does not suppose to work with ID, I will disable it in the code.

Deselecting "Active" but keeping substring causes weird behaviour.
Could you test this on the other field value instead of ID.

Selecting a node, submitting that filter then undoing, and submitting again makes nothing happen at the last step.

I will look into it.
The behaviour is correct. As I metioned in the Description, the filter history is not implemented yet, so it causing confusions at this stage.

A couple of issues I discovered while testing.

We may have a short meeting regarding that.

…e for filter with ID does not support substring filter.

…lter type is ID.

…on with isWildCard default value be false.

…hen there is no filter set.

hry625 and others added 30 commits November 9, 2022 00:12

frontend/LineInputList.svelte:modify the filter option list according…

dcd567d

… to the new design. #10

frontend/FilterWidget.svelte:modify the filter option list according …

0e55e49

…to the new design. #10

frontend: highlight edges of node on hover (ItJustWorksTM#123)

f6f5369

backend/event_sender: add eiffelvis vocabulary and improve sending op…

9cad863

…tions (ItJustWorksTM#121)

backend: Update Cargo.lock (ItJustWorksTM#138)

33187c8

generated by cargo update

backend/domain: split out filter and collection

49594a6

backend: allow client to somewhat control string matching

84edf60

adds lower_case and partial options for now, this means the backend will alter the way the nodes are matched. note: client provided string is not modified.

FrontEnd: Re-factor the overall layout (ItJustWorksTM#141)

0380422

frontend: refactor the overall layout Co-authored-by: Alexandre Rancati-Palmer <71485862+alrapal@users.noreply.github.com> Co-authored-by: Karl Nilsson <44969574+ktpa@users.noreply.github.com>

Frontend:uitypes.ts: add FilterInput interface

59654d8

frontend/FilterWidget.svelte: implement add_filter_to_TempFilterArray…

85e674f

… and add_tempFIlter_to_query

frontend/LineInputList.svelte: change the LineInputList into table

55c7769

frontend/Panel.svelte: call filterpanel's function from Panel component

0466813

frontend/QueryForm.svelte:connect FilterWidget with QueryForm

8728f3c

frontend/LineInputList.svelte: change wildcard to substring

fc4303a

frontend:apidefinition.ts: change event_filter_type_eq function on id…

f38f6f2

…s array

frontend/uitypes.ts: update fixed_query_to_norm function to fit new q…

aceca2a

…uery data structure

frontend/FilterWidget.svelte:update empty filter datastructure

3cf1b42

frontend/App.svelte: update use_selected_as_root function to fit new …

81c6d00

…query datastructure

frontend/Panel.svelte:fix bind warning

9f1cefe

frontend/Panel.svelte&QueryForm.svelte:remove outbound expose of filt…

0dc90c9

…erWidget.

frontend/LineInputList.svelte:update lineinput layout to make it thinner

d3923e2

frontend/App.svelte: implement add_filter_set function

6c6cc50

frontend/Panel.svelte: connect add_filter_set function with the button

8e665bd

update filterWidet

755ae65

frontend/QueryForm.svelte: change filter sets to sub graph filters

6bb781d

frontend/apidefinition.ts:remove unnecessary import

3c9c064

Asiya-Ismail and others added 22 commits January 5, 2023 10:12

frontend: Add non-Interactive mode (ItJustWorksTM#142)

c2500dc

frontend: allow filter panel to be toggled from sidebar (ItJustWorksT…

dda6330

…M#145)

Frontend: Refactor layout and implementation of setting component (It…

35bf76c

…JustWorksTM#146) frontend: Introduce settings window and shuffle code around

frontend/App.svelte&Panel.svelte:code clean up after merge master to …

e3ae799

…filter panel branch.

backend/event_filter.rs:fix error caused by merge

81a41a6

frontend/QueryForm.svelte:fix the substring filter bug

80c1733

frontend/QueryForm.svelte:code clean up and capitalize filters sets t…

0328f0c

…itles.

frontend/FilterWidget.svelte&LineInputList.svelte: lineinput layout u…

cade6b4

…pdate.

frontend/Panel.svelte: change button content so that the user could r…

be7d9e1

…ead.

frontend/App.svelte&Panel.svelte&QueryForm.svelte: implement update f…

055dac3

…ilter set display when use select node as root.

frontend/Panel.svelte:fix submit button disable bug

88ba81c

backend/event_sender: add eiffelvis vocabulary and improve sending op…

da02322

…tions (ItJustWorksTM#121)

backend/domain: split out filter and collection

5ec8f46

backend: allow client to somewhat control string matching

3dce226

adds lower_case and partial options for now, this means the backend will alter the way the nodes are matched. note: client provided string is not modified.

Frontend: Refactor layout and implementation of setting component (It…

1b83973

…JustWorksTM#146) frontend: Introduce settings window and shuffle code around

frontend: Make keyboard navigation play nice with auto scroll (ItJust…

bf9b063

…WorksTM#148)

frontend: keybind and shortcut panel (ItJustWorksTM#149)

aaf5261

Co-authored-by: Alexandre Rancati-Palmer <a.rancatipalmer@mailo.com>

fix after merge error

4c9452b

Merge branch 'master' into US10.1-filter-panel-new-design

9da9ac4

format and bug fix after merge

1c9849a

hry625 marked this pull request as draft January 16, 2023 11:58

hry625 added 5 commits January 17, 2023 17:20

Frontend/QueryForm.svelte:fix typo

225ab3b

frontend/FilterWidget.svelte: change default isWildCard value is fals…

43c898f

…e for filter with ID does not support substring filter.

frontend/LineInputList.svelte:disable substring toggle button when fi…

49dc547

…lter type is ID.

frontend/App.svelte:update add_selected_node_as_root_to_filter functi…

49d987b

…on with isWildCard default value be false.

frontend/LineInputlist.svelte:fix filter panel layout inconsistency w…

9846da7

…hen there is no filter set.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Us10.1 filter panel new design #159

Us10.1 filter panel new design #159

hry625 commented Jan 16, 2023 •

edited

Loading

ktpa commented Jan 17, 2023

hry625 commented Jan 17, 2023 •

edited

Loading

Us10.1 filter panel new design #159

Are you sure you want to change the base?

Us10.1 filter panel new design #159

Conversation

hry625 commented Jan 16, 2023 • edited Loading

Description:

Useful notes:

Screenshots:

ktpa commented Jan 17, 2023

hry625 commented Jan 17, 2023 • edited Loading

hry625 commented Jan 16, 2023 •

edited

Loading

hry625 commented Jan 17, 2023 •

edited

Loading