-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add media save redirect. #971
Conversation
Discussion from the Tech call was that this would break existing redirects. |
I thought a toggle was going to be introduced around it? Could go so far as to have it default to "on" for new installations (as in, "true" in whatever config object under |
Toggle implemented.
Also implemented. |
I am going to try to review this. Seth thought that it may not matter if I use a site with isntall_profile versus starter site. Not sure which one I will use. I will try to put in a patch of this change tot eh islandora module, hit drush updb, then clear cache then test it. |
9db66ae
to
d6e0749
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works!
GitHub Issue: LEAF-VRE/islandora-UX-useathon#3
What does this Pull Request do?
Redirects you to the node page after creating a media from "Add Media".
What's new?
(i.e. Regeneration activity, etc.)? no
How should this be tested?
Create a node and create an attached media. Without this PR, you land at the global media view.
With this PR, you land on a node.
It should also not break when you create a media that is not a member of a node.
This applies only to the creation of new media
Documentation Status
Additional Notes:
Any additional information that you think would be helpful when reviewing this
PR.
Interested parties
Tag (@ mention) interested parties or, if unsure, @Islandora/committers